Closed Bug 1287182 Opened 9 years ago Closed 9 years ago

log angle failureid via ANGLEPlatformInitialize

Categories

(Core :: Graphics: CanvasWebGL, defect)

Product:
Core
Component:
Graphics: CanvasWebGL
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: BenWa, Assigned: BenWa)

References

(Blocks 1 open bug)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file, 1 obsolete file)

Don't clobber the angle platform failureId.
996 bytes, patch
jrmuizel
: review+
Details | Diff | Splinter Review
No description provided.
Assignee: nobody → bgirard
Comment on attachment 8771570 [details] Bug 1287182 - log angle failureid via ANGLEPlatformInitialize. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64682/diff/1-2/
Whiteboard: [gfx-noted]
Comment on attachment 8771570 [details] Bug 1287182 - log angle failureid via ANGLEPlatformInitialize. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64682/diff/2-3/
Attachment #8771570 - Flags: review?(jmuizelaar)
Comment on attachment 8771570 [details] Bug 1287182 - log angle failureid via ANGLEPlatformInitialize. https://reviewboard.mozilla.org/r/64682/#review62054 ::: gfx/angle/moz.build:166 (Diff revision 3) > DEFINES['ANGLE_ENABLE_HLSL'] = "1" > DEFINES['ANGLE_ENABLE_GLSL'] = "1" > DEFINES['ANGLE_ENABLE_ESSL'] = "1" > DEFINES['ANGLE_ENABLE_KEYEDMUTEX'] = "1" > > -EXPORTS.angle += [ 'include/GLSLANG/ShaderLang.h', 'include/GLSLANG/ShaderVars.h' ] > +EXPORTS.angle += [ This file is generated. Don't change the formatting and I'll do the needful.
Attachment #8771570 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8771570 [details] Bug 1287182 - log angle failureid via ANGLEPlatformInitialize. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64682/diff/3-4/
Pushed by jmuizelaar@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d7f56af6ddd2 log angle failureid via ANGLEPlatformInitialize. r=jrmuizel
Pushed by jmuizelaar@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/351c16b1c082 log angle failureid via ANGLEPlatformInitialize. r=jrmuizel https://hg.mozilla.org/integration/mozilla-inbound/rev/8b59e729f75e Fix static analysis build r=jrmuizel.
https://hg.mozilla.org/mozilla-central/rev/d7f56af6ddd2 https://hg.mozilla.org/mozilla-central/rev/351c16b1c082
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8771570 [details] Bug 1287182 - log angle failureid via ANGLEPlatformInitialize. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64682/diff/4-5/
Pushed by b56girard@gmail.com: https://hg.mozilla.org/integration/autoland/rev/cfb99ceaac77 log angle failureid via ANGLEPlatformInitialize. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/cfb99ceaac77
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Flags: needinfo?(bgirard)
Depends on: 1288954
We're clobbering the results by accident.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #8771570 - Attachment is obsolete: true
Attachment #8777557 - Flags: review?(jmuizelaar)
Attachment #8777557 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/eb88d96de254
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: