1287413 - Blank area visible at the bottom of the CSS pane

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P1)

Description

[Ada [:adalucinet]]

[Affected versions]:
- latest Nightly 50.0a1

[Affected platforms]:
- Windows 10 64-bit
- Mac OS X 10.11.1
- Ubuntu 16.04 64-bit

[Steps to reproduce]:
1. Launch Firefox.
2. Open Inspector: Ctrl + Shift + C (for Windows & Ubuntu) or Cmd + Opt + C (for Mac OS X).
3. Click on 'Collapse pane' button.
4. Click on 'Dock to side of browser window'
5. Click on 'Expand pane' button.
6. Drag up the CSS pane

[Expected result]: 
- CSS pane is properly displayed.

[Actual result]: 
- Blank area displayed at the bottom of the CSS pane.

[Regression range]:
- Last good revision: 2f9e69c982f1e67887a1834b36ff0af4ababb3af
- First bad revision: 3db372da6fe108ddb0727003447f22c2483fb86d
- Pushlog: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=2f9e69c982f1e67887a1834b36ff0af4ababb3af&tochange=3db372da6fe108ddb0727003447f22c2483fb86d
- Maybe this was regressed by bug 1259819? 

[Additional notes]:
- Screen recording: https://goo.gl/5wuiaH

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

This could be caused by bug 1287368
Let's retest as soon as it's fixed.

Honza

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: bug1287413.patch

@Patrick, these two lines have been introduced when implementing the (HTML) Sidebar (bug 1259819). They are clearly wrong causing this bug so, I am removing it.

Honza

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/a6c528c3fe72
Avoid blank area in the Sidebar. r=pbro

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out for eslint failures: https://hg.mozilla.org/integration/fx-team/rev/3367c6049a4f1a7f94532da415bba9e5e348e883

 TEST-UNEXPECTED-ERROR | devtools/client/inspector/inspector-panel.js:1222:9 | 'sidePane' is defined but never used (no-unused-vars)

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: bug1287413.patch

(In reply to Wes Kocher (:KWierso) from comment #4)
> I had to back this out for eslint failures:
> https://hg.mozilla.org/integration/fx-team/rev/
> 3367c6049a4f1a7f94532da415bba9e5e348e883
> 
>  TEST-UNEXPECTED-ERROR | devtools/client/inspector/inspector-panel.js:1222:9
> | 'sidePane' is defined but never used (no-unused-vars)
Ah, sorry, updated patch attached.

Honza

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/7378c2265376
Avoid blank area in the Sidebar. r=pbro

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7378c2265376

Comment 8

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I reproduced this issue using Fx 50.0a1, build ID: 20160718081125, on Window 10 x64.
I can confirm the fix on Fx 50.0a1, build ID: 20160725030248.