1287597 - Fix VRManager to work with the GPU process

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

This will be very similar to bug 1287366. It's not strictly needed for the prototype, but I'm including it because a bunch of compositor code expects the VR module to be initialized.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: part 1, use endpoints

More of the same - use Endpoints instead of "opens" in PContent, and make GPUProcessManager responsible for creating the endpoints.

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: part 2, move to GPUProcessManager

This moves VRManager initialization from gfxPlatform to GPUProcessManager.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: part 3, GPU process support

This refactors VRManager{Child|Parent} initialization so it can bridge to the GPU process. This is very similar to the ImageBridge and CompositorBridge patches.

This also makes sure the VRManager is instantiated in the GPU process.

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8772160 [details] [diff] [review]
part 1, use endpoints

Review of attachment 8772160 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/ipc/GPUProcessManager.cpp
@@ +431,5 @@
> +    gfxCriticalNote << "Could not create content compositor bridge: " << hexa(int(rv));
> +    return false;
> +  }
> +
> +  if (!VRManagerParent::CreateForContent(Move(parentPipe)))

Need braces.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f859f324dce
Open content VRManagers using endpoints. (bug 1287597 part 1, r=billm)
https://hg.mozilla.org/integration/mozilla-inbound/rev/50a3f84f013e
Move VRManagerChild initialization to GPUProcessManager. (bug 1287597 part 2, r=mattwoodrow)
https://hg.mozilla.org/integration/mozilla-inbound/rev/04cf459f7fc6
Add VRManager support to the GPU process. (bug 1287597 part 3, r=billm)

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6f859f324dce
https://hg.mozilla.org/mozilla-central/rev/50a3f84f013e
https://hg.mozilla.org/mozilla-central/rev/04cf459f7fc6