1287753 - In-Reply-To: and References: should be removed from mail saved as Template (port bug 726281 to SeaMonkey)

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Composition, defect)

Description

[rsx11m]

+++ This bug was initially created as a clone of Bug #726281 +++

In-Reply-To: and References: should be removed from mail saved as Template.
Straight port of comm-central changeset bbdd29586adf.

Comment 1

[rsx11m]

Attachment: Yet another patch

That's attachment 8772184 [details] [diff] [review] with a slightly different order of the statements.

Note what it's NOT doing: It doesn't change anything for selecting an existing message and then making it a template using File > Save As > Template. It only has an impact when saving as template while *composing* a message.

The use case here being that you Edit as New an existing message, remove or edit any part as wanted, and then save that message as a new template; or, after moving an existing message to Templates and opening it, then saving it after making modifications. In either case, the "References:" and "In-Reply-To:" headers are removed by this patch.

Also removing those headers for File > Save As Template is a bit trickier, given that the SaveAsTemplate() implementation in suite/mailnews/mailCommands.js merely copies the existing message from its current folder into the Templates folder without being able to modify it on the fly.

Comment 2

[rsx11m]

Ping for review - Monday is merge day!

Comment 3

[Philip Chee]

Comment on attachment 8772648 [details] [diff] [review]
Yet another patch

I would prefer the logic to be in GenericSendMessage()
Perhaps inserted just after here:
https://hg.mozilla.org/comm-central/annotate/c4a3561ecc3f/suite/mailnews/compose/MsgComposeCommands.js#l1591
and after here:
https://hg.mozilla.org/comm-central/annotate/c4a3561ecc3f/suite/mailnews/compose/MsgComposeCommands.js#l1635

But I'm open to reasons for putting this patch in SaveAsTemplate()

Comment 4

[rsx11m]

Well, it's *very* specific to Saving As Template, thus putting this in SaveAsTemplate() makes sense given that you don't want to remove the In-Reply-to/References headers in any other cases (including Save As Draft or sending the message as such). In GenericSendMessage(), it would require a test for invoking it in the context of Save As Template, which would be redundant at that point. Also, handling of savedPreferences seems to be more transparent in SaveAsTemplate(), i.e., easier to read.

On a side note, I'd rename savedPreferences to savedReferences in either case. ;-)

Comment 5

[Philip Chee]

Comment on attachment 8772648 [details] [diff] [review]
Yet another patch

Fair enough. r=me a=me please land on relevant branches a=me on that too.

Comment 6

[rsx11m]

Attachment: Patch as checked in (v2)

http://hg.mozilla.org/comm-central/rev/2566ea557085
http://hg.mozilla.org/releases/comm-aurora/rev/7b4065981cd4
http://hg.mozilla.org/releases/comm-beta/rev/ed49e64ed546
http://hg.mozilla.org/releases/comm-release/rev/64ee8c5d4194

Comment 7

[rsx11m]

In retrospect, pushing to comm-release was mood as we are going for a 2.46 release rather than 2.45. Thanks for the review, I've opened bug 1303552 to correct the variable name in Thunderbird as well.