Closed Bug 1288103 Opened 8 years ago Closed 8 years ago

Add build/feature flag for activity stream features

Categories

(Firefox for Android Graveyard :: General, defect, P1)

All
Android
defect

Tracking

(firefox50 fixed)

RESOLVED FIXED
Firefox 50
Tracking Status
firefox50 --- fixed

People

(Reporter: sebastian, Assigned: ahunt)

References

Details

(Whiteboard: [MobileAS])

Attachments

(1 file)

We want to start writing and landing code for activity stream. Introduce a new build flag (mirrored in AppConstants) that we can use to enable/disable this work.

For now this flag can be disabled by default. Later we can enable this for Nightly or other release channels.
Assignee: nobody → ahunt
Status: NEW → ASSIGNED
Comment on attachment 8773370 [details]
Bug 1288103 - Add experimental MOZ_ANDROID_ACTIVITY_STREAM build flag

https://reviewboard.mozilla.org/r/66080/#review63114

::: mobile/android/moz.configure:59
(Diff revision 1)
> +option('--enable-android-activity-stream', env='MOZ_ANDROID_ACTIVITY_STREAM',
> +       help='Enable the activity stream prototype and use it in place of the HomePager')
> +
> +set_define('MOZ_ANDROID_ACTIVITY_STREAM', depends_if('--enable-android-activity-stream')(lambda _: True))

A simple project flag, like we did for custom tabs, might be enough here, I think:
https://dxr.mozilla.org/mozilla-central/rev/4c05938a64a7fde3ac2d7f4493aee1c5f2ad8a0a/mobile/android/moz.configure#40-42
Attachment #8773370 - Flags: review?(s.kaspari)
Comment on attachment 8773370 [details]
Bug 1288103 - Add experimental MOZ_ANDROID_ACTIVITY_STREAM build flag

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/66080/diff/1-2/
Attachment #8773370 - Attachment description: Bug 1288103 - Add experimental --enable-android-activity-stream build flag → Bug 1288103 - Add experimental MOZ_ANDROID_ACTIVITY_STREAM build flag
Attachment #8773370 - Flags: review?(cmanchester)
Comment on attachment 8773370 [details]
Bug 1288103 - Add experimental MOZ_ANDROID_ACTIVITY_STREAM build flag

https://reviewboard.mozilla.org/r/66080/#review63264

::: mobile/android/base/moz.build:983
(Diff revision 2)
>              'MOZ_APP_DISPLAYNAME', 'MOZ_APP_UA_NAME', 'MOZ_APP_ID', 'MOZ_APP_NAME',
>              'MOZ_APP_VENDOR', 'MOZ_APP_VERSION', 'MOZ_CHILD_PROCESS_NAME',
>              'MOZ_ANDROID_APPLICATION_CLASS', 'MOZ_ANDROID_BROWSER_INTENT_CLASS', 'MOZ_ANDROID_SEARCH_INTENT_CLASS',
>              'MOZ_CRASHREPORTER', 'MOZ_UPDATE_CHANNEL', 'OMNIJAR_NAME',
> -            'OS_TARGET', 'TARGET_XPCOM_ABI'):
> +            'OS_TARGET', 'TARGET_XPCOM_ABI',
> +            'MOZ_ANDROID_ACTIVITY_STREAM'):

Does this work, after a clobber? I was wrong a minute ago, I don't think a random variable from a mozconfig would propogate to moz.build without help from configure.

Putting this in moz.configure is a good way to make this a little more visible, as well.

Once that's sorted out, this variable might be a little more at home up in the loop at line 963.
Attachment #8773370 - Flags: review?(cmanchester)
(In reply to Chris Manchester (:chmanchester) from comment #4)
> Does this work, after a clobber? I was wrong a minute ago, I don't think a
> random variable from a mozconfig would propogate to moz.build without help
> from configure.
> 
> Putting this in moz.configure is a good way to make this a little more
> visible, as well.
> 
> Once that's sorted out, this variable might be a little more at home up in
> the loop at line 963.

Yeah, it turns out this didn't work (and with my patch moz.build always sets MOZ_ANDROID_ACTIVITY_STREAM regardless of the mozconfig).
Comment on attachment 8773370 [details]
Bug 1288103 - Add experimental MOZ_ANDROID_ACTIVITY_STREAM build flag

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/66080/diff/2-3/
Attachment #8773370 - Flags: review?(cmanchester)
Attachment #8773370 - Flags: review?(cmanchester) → review+
Comment on attachment 8773370 [details]
Bug 1288103 - Add experimental MOZ_ANDROID_ACTIVITY_STREAM build flag

https://reviewboard.mozilla.org/r/66080/#review63742

::: mobile/android/moz.configure:53
(Diff revision 3)
>               help='Include Switchboard A/B framework on Android',
>               default=True)
>  
> +option(env='MOZ_ANDROID_ACTIVITY_STREAM',
> +       help='Enable Activity Stream on Android (replacing the default HomePager)',
> +       default=False)

I'm pretty sure the default default is unset, but feel free to leave this for clarity.
https://hg.mozilla.org/integration/fx-team/rev/268d2ffd7a0541073df31abd121e0e6002cb73c4
Bug 1288103 - Add experimental MOZ_ANDROID_ACTIVITY_STREAM build flag r=chmanchester
Pushed by ahunt@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/268d2ffd7a05
Add experimental MOZ_ANDROID_ACTIVITY_STREAM build flag r=chmanchester
https://hg.mozilla.org/mozilla-central/rev/268d2ffd7a05
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Whiteboard: [MobileAS s1.1]
Priority: -- → P1
Whiteboard: [MobileAS s1.1] → [MobileAS]
Iteration: --- → 1.1
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: