1288107 - For users with only one other device, remove "All devices" from send page/link/tab menu

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Ryan Feeley [:rfeeley]]

Most users who have multiple devices will only have two. We should only show "All devices" for users with more than two and remove any dividers as well.

Comment 1

[Edouard Oger [:eoger]]

Attachment: Bug 1288107 - Remove All Devices option in Send Tab to Device menu when we only have 1 other device.

Review commit: https://reviewboard.mozilla.org/r/66234/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66234/

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8773487 [details]
Bug 1288107 - Remove All Devices option in Send Tab to Device menu when we only have 1 other device.

https://reviewboard.mozilla.org/r/66234/#review63074

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/6df391343333
Remove All Devices option in Send Tab to Device menu when we only have 1 other device. r=markh

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6df391343333

Comment 5

[Camelia Badau [:cbadau], Desktop Test Engineering]

I've reproduced the initial issue on Nightly 50.0a1 (2016-07-20): "All devices" option is displayed even if the user has 1 other device.

The "Send Tab to Device" ride the trains - please see bug 1297454 . Also, the "Send Tab to Device" is enabled on non-nightly builds from Firefox 52 - please see bug 1304534. 

In this case, I verified the bug on Nightly 50.0a1 (2016-07-26) and on latest Nightly 52.0a1 (2016-10-26): the issue is no longer reproducible: the "All devices" option is displayed only for users that have multiple (two or more) other devices. If the user has 1 other device, the "All devices" options isn't anymore displayed. 

Marking the issue as VERIFIED FIXED.