1288256 - Make home screen implementation pluggable

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect, P1)

Description

[Andrzej Hunt :ahunt]

The HomePager seems to pervade large parts of the codebase. We should extract its interface to allow plugging in different home screen implementations (needed for the AS prototype panel in Bug 1288124).

This is a preparatory bug for Bug 1288124, we can disentangle the HomePager separately from adding a new screen. / switching mechanism.

Current terminology (not sure this is ideal, we can change that if needed):
Home Panel: refers only to the existing home panels that are used in the HomePager
Home Screen(s): any implementation of views/data/etc that can be displayed on the home screen, e.g. the current HomePager is a "home screen", the new Activity Stream panel will be another "home screen".

Maybe we should rename the current "home panels" to "homepager panels", and then the Home Pager and AS Panel can be called "home panels"?

Comment 1

[Andrzej Hunt :ahunt]

Attachment: Bug 1288256 - Pre: remove unneeded imports

Review commit: https://reviewboard.mozilla.org/r/66064/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66064/

Comment 2

[Andrzej Hunt :ahunt]

Attachment: Bug 1288256 - Part 1: update naming of "home pager container" to "home screen container"

This is to help keep the terminology more clear: this container will allow displaying any of our
home screen implementations, and not just the HomePager.

Review commit: https://reviewboard.mozilla.org/r/66066/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66066/

Comment 3

[Andrzej Hunt :ahunt]

Attachment: Bug 1288256 - Part 2: extract HomePager interface into HomeScreen

This will permit us to plug in other HomeScreen implementations as needed.

Review commit: https://reviewboard.mozilla.org/r/66068/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66068/

Comment 4

[Andrzej Hunt :ahunt]

Attachment: Bug 1288256 - Part 3: update BrowserApp to use HomeScreen interface instead of HomePager

Review commit: https://reviewboard.mozilla.org/r/66070/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66070/

Comment 5

[Andrzej Hunt :ahunt]

Attachment: Bug 1288256 - Post: add comments explaining HomePager specific methods in HomeScreen

Review commit: https://reviewboard.mozilla.org/r/66072/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66072/

Comment 6

[Andrzej Hunt :ahunt]

Comment on attachment 8773327 [details]
Bug 1288256 - Part 2: extract HomePager interface into HomeScreen

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/66068/diff/1-2/

Comment 7

[Andrzej Hunt :ahunt]

Comment on attachment 8773328 [details]
Bug 1288256 - Part 3: update BrowserApp to use HomeScreen interface instead of HomePager

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/66070/diff/1-2/

Comment 8

[Andrzej Hunt :ahunt]

Comment on attachment 8773329 [details]
Bug 1288256 - Post: add comments explaining HomePager specific methods in HomeScreen

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/66072/diff/1-2/

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8773325 [details]
Bug 1288256 - Pre: remove unneeded imports

https://reviewboard.mozilla.org/r/66064/#review62942

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8773326 [details]
Bug 1288256 - Part 1: update naming of "home pager container" to "home screen container"

https://reviewboard.mozilla.org/r/66066/#review62944

Comment 11

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8773327 [details]
Bug 1288256 - Part 2: extract HomePager interface into HomeScreen

https://reviewboard.mozilla.org/r/66068/#review62946

Comment 12

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8773328 [details]
Bug 1288256 - Part 3: update BrowserApp to use HomeScreen interface instead of HomePager

https://reviewboard.mozilla.org/r/66070/#review62948

Comment 13

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8773329 [details]
Bug 1288256 - Post: add comments explaining HomePager specific methods in HomeScreen

https://reviewboard.mozilla.org/r/66072/#review62950

Comment 14

[Sebastian Kaspari (:sebastian; :pocmo)]

Nice! I was a bit afraid that we'd over-engineer this because eventually we should end up with only one home screen implementation again (after prototyping/testing). But all this here seems to be sane. :)

Comment 15

[Andrzej Hunt :ahunt]

https://hg.mozilla.org/integration/fx-team/rev/e0af49e9e91d448b0b72f5693fa2596eb5f80810
Bug 1288256 - Pre: remove unneeded imports r=me

https://hg.mozilla.org/integration/fx-team/rev/29e25d7d906a2d69c25483fa76c9595e07659e64
Bug 1288256 - Part 1: update naming of "home pager container" to "home screen container" r=sebastian

https://hg.mozilla.org/integration/fx-team/rev/e68f8bf2096ea5986e1d17facdc06b3da7258a3d
Bug 1288256 - Part 2: extract HomePager interface into HomeScreen r=sebastian

https://hg.mozilla.org/integration/fx-team/rev/35add519e9f4ae0c4f03befb6483d1fc255a5ad7
Bug 1288256 - Part 3: update BrowserApp to use HomeScreen interface instead of

https://hg.mozilla.org/integration/fx-team/rev/bd6655e7b879214b7d983ca85c8160a77a653178
Bug 1288256 - Post: add comments explaining HomePager specific methods in HomeScreen r=sebastian

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e0af49e9e91d
https://hg.mozilla.org/mozilla-central/rev/29e25d7d906a
https://hg.mozilla.org/mozilla-central/rev/e68f8bf2096e
https://hg.mozilla.org/mozilla-central/rev/35add519e9f4
https://hg.mozilla.org/mozilla-central/rev/bd6655e7b879