Closed Bug 1288568 Opened 8 years ago Closed 8 years ago

Pixel-snap "+" icon in devtools

Categories

(DevTools :: Inspector, defect, P2)

Product:
DevTools
Component:
Inspector
Type:
defect

Tracking

(firefox50 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 50
Tracking Flags:
Tracking Status
firefox50 --- verified

People

(Reporter: ntim, Assigned: ntim)

References

Details

Attachments

(1 file)

patch
1000 bytes, patch
hholmes
: review+
Details | Diff | Splinter Review 
      No description provided.
Attached patch patch — — Splinter Review 
It's now off-centre, but it won't be blurry on 1x screens.
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Attachment #8773549 - Flags: review?(hholmes)
See Also: → 1287396
Inspector bug triage (filter on CLIMBING SHOES).
Priority: -- → P2
Comment on attachment 8773549 [details] [diff] [review]
patch

Looks good to me! I think the pixel snapping is more important than being perfectly centered.
Attachment #8773549 - Flags: review?(hholmes) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/8aecdaace020
Pixel snap add.svg. r=helenvholmes
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8aecdaace020
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
I've see this issue on this bug in Nightly 50.0a1 (2016-07-21) ; (Build ID: 20160721030216) from Linux.

This Bug is now verified as fixed on Latest Firefox Nightly 50.0a1 (2016-07-30)

Build ID: 20160730030204
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0
OS: Linux 4.4.0-31-generic ; Ubuntu 16.04 (64 Bit)
QA Whiteboard: [bugday-20160727]
Status: RESOLVED → VERIFIED
status-firefox50: fixed → verified
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: