Closed
Bug 1288687
Opened 8 years ago
Closed 8 years ago
Adjust l20n.js's linting rules for landing in mozilla-central
Categories
(L20n :: JS Library, defect)
L20n
JS Library
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stas, Assigned: stas)
References
Details
(Whiteboard: [gecko-l20n])
Attachments
(2 files)
I'm currently seeing minor linting errors on try which should be easy to fix:
TEST-UNEXPECTED-ERROR | toolkit/content/l20n-chrome-xul.js:307:80 | Trailing spaces not allowed. (no-trailing-spaces)
TEST-UNEXPECTED-ERROR | toolkit/content/l20n-chrome-xul.js:787:2 | Newline required at end of file but not found. (eol-last)
TEST-UNEXPECTED-ERROR | toolkit/modules/IntlMessageContext.jsm:579:47 | Trailing spaces not allowed. (no-trailing-spaces)
TEST-UNEXPECTED-ERROR | toolkit/modules/IntlMessageContext.jsm:1175:79 | Trailing spaces not allowed. (no-trailing-spaces)
TEST-UNEXPECTED-ERROR | toolkit/modules/IntlMessageContext.jsm:1243:2 | Newline required at end of file but not found. (eol-last)
TEST-UNEXPECTED-ERROR | toolkit/modules/L10nRegistry.jsm:113:1 | Trailing spaces not allowed. (no-trailing-spaces)
TEST-UNEXPECTED-ERROR | toolkit/modules/L10nRegistry.jsm:209:1 | Trailing spaces not allowed. (no-trailing-spaces)
TEST-UNEXPECTED-ERROR | toolkit/modules/L10nRegistry.jsm:274:68 | Trailing spaces not allowed. (no-trailing-spaces)
Comment 1•8 years ago
|
||
Mass change dependency tree for bug 1279002 into a whiteboard keyword.
No longer blocks: gecko-l20n
Whiteboard: [gecko-l20n]
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → stas
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•8 years ago
|
||
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #8782873 -
Flags: review?(gandalf)
Comment 5•8 years ago
|
||
mozreview-review |
Comment on attachment 8782870 [details]
Bug 1288687 - Fix lint errors.
https://reviewboard.mozilla.org/r/72904/#review70748
Attachment #8782870 -
Flags: review?(gandalf) → review+
Updated•8 years ago
|
Attachment #8782873 -
Flags: review?(gandalf) → review+
Assignee | ||
Comment 6•8 years ago
|
||
https://hg.mozilla.org/projects/larch/rev/7bd2db006a53a1918e9de3149d404e54a6319062
Bug 1288687 - Fix lint errors. r=gandalf
Assignee | ||
Comment 7•8 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•