When serializing a url() with the local url flag set, it must serialize as just the fragment.

RESOLVED FIXED in Firefox 51

Status

()

Core
DOM
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: cjku, Assigned: cjku)

Tracking

unspecified
mozilla51
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

a year ago
According to Fragment URLs defined in [1], when serializing a url() with the local url flag set, it must serialize as just the fragment.

[1]https://drafts.csswg.org/css-values/#local-urls
(Assignee)

Comment 1

a year ago
Created attachment 8778477 [details]
Bug 1288812 - Part 1. Serialize just the fragment for local urls.

Review commit: https://reviewboard.mozilla.org/r/69782/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69782/
(Assignee)

Comment 2

a year ago
Created attachment 8778478 [details]
Bug 1288812 - Part 2. Correct test cases.

Review commit: https://reviewboard.mozilla.org/r/69784/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69784/
(Assignee)

Updated

a year ago
Depends on: 1291280
(Assignee)

Comment 3

a year ago
Comment on attachment 8778477 [details]
Bug 1288812 - Part 1. Serialize just the fragment for local urls.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69782/diff/1-2/
(Assignee)

Comment 4

a year ago
Comment on attachment 8778478 [details]
Bug 1288812 - Part 2. Correct test cases.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69784/diff/1-2/
(Assignee)

Updated

a year ago
Attachment #8778477 - Flags: review?(cam)
Attachment #8778478 - Flags: review?(cam)
Comment on attachment 8778477 [details]
Bug 1288812 - Part 1. Serialize just the fragment for local urls.

https://reviewboard.mozilla.org/r/69782/#review67008

::: layout/style/nsComputedDOMStyle.cpp:78
(Diff revision 2)
>                                           aStyleType);
>    return computedStyle.forget();
>  }
>  
> +static void
> +FragmentOrURLToROCSSPrimitiveValue(const FragmentOrURL* aFragmentOrURL,

Some other similar functions in this file just use "Value" in their name to refer to the target nsROCSSPrimitiveValue, like SetValueToStyleImage, SetValueToPositionCoord, SetValueToPosition.  So let's use similar naming here -- SetValueToFragmentOrURL.
Attachment #8778477 - Flags: review?(cam) → review+
Comment on attachment 8778478 [details]
Bug 1288812 - Part 2. Correct test cases.

https://reviewboard.mozilla.org/r/69784/#review67012

Can we add some specific tests for this new serialization, too?  Something that checks that when we use url(#a) that it serializes like that and when we use url(name_of_test_file.html#a) that it serializes to the absolute URL?
Attachment #8778478 - Flags: review?(cam) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 11

a year ago
Pushed by cku@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/279cf3d56811
Part 1. Serialize just the fragment for local urls. r=heycam
https://hg.mozilla.org/integration/autoland/rev/b396323fb8a7
Part 2. Correct test cases. r=heycam

Comment 12

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/279cf3d56811
https://hg.mozilla.org/mozilla-central/rev/b396323fb8a7
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
(Assignee)

Comment 13

a year ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d754bde37ab9b7d3f25bd569b77cdfd4ee7e423
Bug 1288812 - (follow-up) Part 3. Correct test_transitions_per_property.html.
(Assignee)

Comment 14

a year ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e84e72b0a967bcbc362e1a66685d87f49e850bdd
Bug 1288812 - (follow-up) Part 3. Correct test_transitions_per_property.html. r=me

Comment 15

a year ago
Backout by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6742cb73d63f
Backed out changeset 0d754bde37ab for CJKu's request

Comment 16

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e84e72b0a967
You need to log in before you can comment on or make changes to this bug.