Declare nsStyleImageLayers::Layer::mSourceURI as FragmentOrURI

RESOLVED FIXED in Firefox 51

Status

()

Core
Layout
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: cjku, Assigned: cjku)

Tracking

unspecified
mozilla51
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Assignee)

Description

a year ago
A follow-up of bug 652991. Keep this url valid after window.history.pushState
(Assignee)

Updated

a year ago
Blocks: 1288812
(Assignee)

Comment 1

a year ago
Created attachment 8778497 [details]
Bug 1291280 - Part 1. Move the definition of FragmentOrURL up.

Review commit: https://reviewboard.mozilla.org/r/69796/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69796/
(Assignee)

Comment 2

a year ago
Created attachment 8778498 [details]
Bug 1291280 - Part 2. Declare nsStyleImageLayers::Layer::mSourceURI as FragmentOrURI

Review commit: https://reviewboard.mozilla.org/r/69798/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69798/
(Assignee)

Comment 3

a year ago
Created attachment 8778542 [details]
Bug 1291280 - Part 3. Create mask local-ref test cases.

Review commit: https://reviewboard.mozilla.org/r/69814/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69814/
(Assignee)

Updated

a year ago
Attachment #8778497 - Flags: review?(cam)
Attachment #8778498 - Flags: review?(cam)
Attachment #8778542 - Flags: review?(cam)
(Assignee)

Comment 4

a year ago
hi heycam,
This is a simple follow up of bug 652991 - replace type of mask uri from nsIURI to FragementOrURL.
Comment on attachment 8778497 [details]
Bug 1291280 - Part 1. Move the definition of FragmentOrURL up.

https://reviewboard.mozilla.org/r/69796/#review67016
Attachment #8778497 - Flags: review?(cam) → review+
https://reviewboard.mozilla.org/r/69798/#review67018

::: layout/style/nsRuleNode.cpp:6660
(Diff revision 1)
>                    aConditions);
>    }
>  };
>  
>  template <>
> -struct BackgroundItemComputer<nsCSSValueList, nsCOMPtr<nsIURI> >
> +struct BackgroundItemComputer<nsCSSValueList, FragmentOrURL >

Nit: while touching this line, you can remove the space before the ">", which isn't needed these days.

::: layout/svg/nsSVGEffects.cpp:393
(Diff revision 1)
>      frame->GetContent()->AsElement(), nsRestyleHint(0), changeHint);
>  }
>  
>  NS_IMPL_ISUPPORTS(nsSVGMaskProperty, nsISupports)
>  
> +static already_AddRefed<nsIURI> GetMaskURI(nsIFrame* aFrame, uint32_t aIndex);

All the other GetXXXURI functions that were added are static methods on nsSVGEffects, so we should do the same to be consistent.
Comment on attachment 8778498 [details]
Bug 1291280 - Part 2. Declare nsStyleImageLayers::Layer::mSourceURI as FragmentOrURI

https://reviewboard.mozilla.org/r/69798/#review67020
Attachment #8778498 - Flags: review?(cam) → review+
Comment on attachment 8778542 [details]
Bug 1291280 - Part 3. Create mask local-ref test cases.

https://reviewboard.mozilla.org/r/69814/#review67022

::: layout/reftests/bugs/reftest.list:1970
(Diff revision 1)
>  
>  HTTP == 652991-1a.html 652991-1-ref.html
>  HTTP == 652991-1b.html 652991-1-ref.html
>  HTTP == 652991-2.html 652991-2-ref.html
>  HTTP == 652991-3.html 652991-3-ref.html
> +HTTP == 652991-3.html 652991-3-ref.html

Remove this duplicated line.
Attachment #8778542 - Flags: review?(cam) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 12

a year ago
Pushed by cku@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a854669c6103
Part 1. Move the definition of FragmentOrURL up. r=heycam
https://hg.mozilla.org/integration/autoland/rev/b2d3fed9052a
Part 2. Declare nsStyleImageLayers::Layer::mSourceURI as FragmentOrURI r=heycam
https://hg.mozilla.org/integration/autoland/rev/2f4de63ff19e
Part 3. Create mask local-ref test cases. r=heycam

Comment 13

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a854669c6103
https://hg.mozilla.org/mozilla-central/rev/b2d3fed9052a
https://hg.mozilla.org/mozilla-central/rev/2f4de63ff19e
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51

Comment 14

a year ago
Pushed by cku@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9bd1de57490e
Part 4. Fix compile error after enable-mask-as-shorthand. r=me

Comment 15

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9bd1de57490e
You need to log in before you can comment on or make changes to this bug.