Closed Bug 1288897 Opened 4 years ago Closed 4 years ago

Fix devtools-responsiveui-close icon color

Categories

(DevTools :: Responsive Design Mode, defect, P1)

defect

Tracking

(firefox49 unaffected, firefox50+ verified, firefox51 verified)

VERIFIED FIXED
Firefox 51
Tracking Status
firefox49 --- unaffected
firefox50 + verified
firefox51 --- verified

People

(Reporter: magicp.jp, Assigned: ntim)

References

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20160722030235

Steps to reproduce:

1. Start Nightly
2. Open DevTools > Responsive Design Mode (Ctrl+Shit+M)
3. Check devtools-responsiveui-close icon color and horizontal alignment


Actual results:

devtools-responsiveui-close icon is not inverted and horizontal alignment is not center.

Regression range: (for icon inverted)
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=664bd6aa11e1c9e53f5e6e7bca4990265b563802&tochange=7ba94e0c5daa48d7667519c930eca31d98648512


Expected results:

devtools-responsiveui-close icon should be applied invert filter and centering.
Blocks: 1268591
Has Regression Range: --- → yes
Has STR: --- → yes
Component: Untriaged → Developer Tools: Responsive Design Mode
OS: Unspecified → All
Hardware: Unspecified → All
The centering is not a regression of bug 1268591.
:ntim, do you plan to look at the color inversion portion of this?
Flags: needinfo?(ntim.bugs)
Filed bug 1289506 for the alignment.
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Flags: needinfo?(ntim.bugs)
Summary: Fix devtools-responsiveui-close icon color and horizontal alignment → Fix devtools-responsiveui-close icon color
Comment on attachment 8775929 [details]
Bug 1288897 - Fix devtools-responsiveui-close icon color.

https://reviewboard.mozilla.org/r/67948/#review65366

Looks good to me, thanks!  Sorry for the delay, I suppose this will need an uplift to 50 now.
Attachment #8775929 - Flags: review?(jryans) → review+
[Tracking Requested - why for this release]: Needs uplift to 50 to resolve DevTools CSS regression.
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/43d4b85bc172
Fix devtools-responsiveui-close icon color. r=jryans
Keywords: checkin-needed
Comment on attachment 8775929 [details]
Bug 1288897 - Fix devtools-responsiveui-close icon color.

Approval Request Comment
[Feature/regressing bug #]: bug 1268591
[User impact if declined]: low visibility of close icon in responsive design mode
[Describe test coverage new/current, TreeHerder]: on fx-team
[Risks and why]: low, straightforward css fix
[String/UUID change made/needed]: none
Attachment #8775929 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/43d4b85bc172
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
I have reproduced this Bug on Nightly 50.0a1 (2016-07-23)  on Windows 10, 64 Bit!

The bug's fix is now verified on latest  Nightly 51.0a1 (2016-08-04)

Nightly 51.0a1:
Build ID 	20160804030441
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:51.0) Gecko/20100101 Firefox/51.0

[bugday-20160803]
Comment on attachment 8775929 [details]
Bug 1288897 - Fix devtools-responsiveui-close icon color.

CSS only, Aurora50+
Attachment #8775929 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Please follow up bug 1289506
I have reproduced this bug with Nightly 50.0a1 (2016-07-23) on Windows 8.1(64Bit!).

This bug's fix is verified on Latest Aurora 50.0a2 .
Build ID :20160825004011
User Agent :Mozilla/5.0 (Windows NT 6.3; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0

[bugday-20160824]
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.