1288897 - Fix devtools-responsiveui-close icon color

Status: VERIFIED FIXED

(DevTools :: Responsive Design Mode, defect, P1)

Description

[magicp]

Attachment: Fix-devtools-responsiveui-close-icon-color-and-horizontal-alignment.png

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20160722030235

Steps to reproduce:

1. Start Nightly
2. Open DevTools > Responsive Design Mode (Ctrl+Shit+M)
3. Check devtools-responsiveui-close icon color and horizontal alignment


Actual results:

devtools-responsiveui-close icon is not inverted and horizontal alignment is not center.

Regression range: (for icon inverted)
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=664bd6aa11e1c9e53f5e6e7bca4990265b563802&tochange=7ba94e0c5daa48d7667519c930eca31d98648512


Expected results:

devtools-responsiveui-close icon should be applied invert filter and centering.

Comment 1

[Tim Nguyen :ntim]

The centering is not a regression of bug 1268591.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

:ntim, do you plan to look at the color inversion portion of this?

Comment 3

[Tim Nguyen :ntim]

Filed bug 1289506 for the alignment.

Comment 4

[Tim Nguyen :ntim]

Attachment: Bug 1288897 - Fix devtools-responsiveui-close icon color.

Review commit: https://reviewboard.mozilla.org/r/67948/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67948/

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8775929 [details]
Bug 1288897 - Fix devtools-responsiveui-close icon color.

https://reviewboard.mozilla.org/r/67948/#review65366

Looks good to me, thanks!  Sorry for the delay, I suppose this will need an uplift to 50 now.

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

[Tracking Requested - why for this release]: Needs uplift to 50 to resolve DevTools CSS regression.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/43d4b85bc172
Fix devtools-responsiveui-close icon color. r=jryans

Comment 8

[Tim Nguyen :ntim]

Comment on attachment 8775929 [details]
Bug 1288897 - Fix devtools-responsiveui-close icon color.

Approval Request Comment
[Feature/regressing bug #]: bug 1268591
[User impact if declined]: low visibility of close icon in responsive design mode
[Describe test coverage new/current, TreeHerder]: on fx-team
[Risks and why]: low, straightforward css fix
[String/UUID change made/needed]: none

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/43d4b85bc172

Comment 10

[Saddam Hossain]

I have reproduced this Bug on Nightly 50.0a1 (2016-07-23)  on Windows 10, 64 Bit!

The bug's fix is now verified on latest  Nightly 51.0a1 (2016-08-04)

Nightly 51.0a1:
Build ID 	20160804030441
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:51.0) Gecko/20100101 Firefox/51.0

[bugday-20160803]

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8775929 [details]
Bug 1288897 - Fix devtools-responsiveui-close icon color.

CSS only, Aurora50+

Comment 12

[Tim Nguyen :ntim]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8771593a4140

Comment 13

[magicp]

Please follow up bug 1289506

Comment 14

[Azmina]

I have reproduced this bug with Nightly 50.0a1 (2016-07-23) on Windows 8.1(64Bit!).

This bug's fix is verified on Latest Aurora 50.0a2 .
Build ID :20160825004011
User Agent :Mozilla/5.0 (Windows NT 6.3; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0

[bugday-20160824]