Keys with special characters are not displayed correctly

RESOLVED FIXED

Status

Webtools
Telemetry Dashboard
P3
normal
RESOLVED FIXED
2 years ago
9 months ago

People

(Reporter: gerald, Assigned: adrian17, Mentored)

Tracking

Trunk

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug] [lang=js], URL)

(Reporter)

Description

2 years ago
See: https://telemetry.mozilla.org/new-pipeline/dist.html#max_channel_version=nightly%252F50&measure=VIDEO_HIDDEN_PLAY_TIME_PERCENTAGE

The VIDEO_HIDDEN_PLAY_TIME_PERCENTAGE telemetry is keyed.
Keys include 'V,0<=h<240' or 'AV,240<=h<480'.
However on the telemetry website they show up as 'V,0,' or 'AV,240,'.

The JSON export contains the full keys, so my guess is that the '<' character is not properly converted to its HTML entity for web display.

Updated

a year ago
Mentor: chutten
Priority: -- → P3
Whiteboard: [good first bug] [lang=js]

Comment 1

a year ago
I want to work on this bug.Please assign it to me.

Comment 2

a year ago
I would like to work on this project. Could you please assign it to me.

Comment 3

a year ago
(In reply to vdivya51991 from comment #2)
> I would like to work on this project. Could you please assign it to me.

Certainly. Please let me know if you have any questions!
Assignee: nobody → vdivya51991

Updated

a year ago
Assignee: vdivya51991 → nobody

Comment 4

11 months ago
Hey Chris,
Can you assign this bug to me, if it's not fixed yet?

Regards

Comment 5

11 months ago
Certainly!

If you have any questions, please feel free to needinfo? me here and I'll get back to you as soon as I can.
Assignee: nobody → itsmohitt

Comment 6

11 months ago
I suppose some background information would be helpful:

The problematic code is in the github repo https://github.com/mozilla/telemetry-dashboard in new-pipeline/src

The bug is to find the code responsible for setting the plot titles and ensure it uses appropriate entities/escapes that it can display things properly.

Updated

10 months ago
Assignee: itsmohitt → nobody

Updated

9 months ago
Assignee: nobody → adrian.wielgosik
Status: NEW → ASSIGNED

Comment 7

9 months ago
The PR has landed and has been deployed to production: https://mzl.la/2wPamZw (you may need to force-reload to dump your cache and see the change)

All done! Need some help finding a new issue to tackle? bug 1365751 currently needs a very similar kind of help to what you provided here.

Updated

9 months ago
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.