1288949 - Keys with special characters are not displayed correctly

Status: RESOLVED FIXED

(Data Platform and Tools :: General, defect, P3)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

See: https://telemetry.mozilla.org/new-pipeline/dist.html#max_channel_version=nightly%252F50&measure=VIDEO_HIDDEN_PLAY_TIME_PERCENTAGE

The VIDEO_HIDDEN_PLAY_TIME_PERCENTAGE telemetry is keyed.
Keys include 'V,0<=h<240' or 'AV,240<=h<480'.
However on the telemetry website they show up as 'V,0,' or 'AV,240,'.

The JSON export contains the full keys, so my guess is that the '<' character is not properly converted to its HTML entity for web display.

Comment 1

[Hemant Singh Patwal]

I want to work on this bug.Please assign it to me.

Comment 2

[vdivya51991]

I would like to work on this project. Could you please assign it to me.

Comment 3

[Chris H-C :chutten]

(In reply to vdivya51991 from comment #2)
> I would like to work on this project. Could you please assign it to me.

Certainly. Please let me know if you have any questions!

Comment 4

[itsmohitt]

Hey Chris,
Can you assign this bug to me, if it's not fixed yet?

Regards

Comment 5

[Chris H-C :chutten]

Certainly!

If you have any questions, please feel free to needinfo? me here and I'll get back to you as soon as I can.

Comment 6

[Chris H-C :chutten]

I suppose some background information would be helpful:

The problematic code is in the github repo https://github.com/mozilla/telemetry-dashboard in new-pipeline/src

The bug is to find the code responsible for setting the plot titles and ensure it uses appropriate entities/escapes that it can display things properly.

Comment 7

[Chris H-C :chutten]

The PR has landed and has been deployed to production: https://mzl.la/2wPamZw (you may need to force-reload to dump your cache and see the change)

All done! Need some help finding a new issue to tackle? bug 1365751 currently needs a very similar kind of help to what you provided here.