1287987 - Telemetry to support background video decoder suspend: Percentage hidden/total play time, keyed by audio presence and height ranges

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

To help tweak the decoder-suspend functionality, we want to measure how much videos actually play while hidden.
The telemetry probe will be similar to VIDEO_HIDDEN_PLAY_TIME_MS, but will record the percentage of time the video is hidden relative to the total play time.
Unplayed or invalid videos are not counted.
Telemetry will be keyed by audio presence ('AV' with audio, 'V' video only), and by resolution ranges (e.g. '720<h<=1080'). An 'All' key will also accumulate all numbers.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1287987 - Histogram for VIDEO_HIDDEN_PLAY_TIME_PERCENTAGE -

Telemetry probe, for feedback (using r? in mozreview) by telemetry peer.

Keying by audio presence and height range will help us better understand how
much benefit we should effectively get for the video population out there.

Review commit: https://reviewboard.mozilla.org/r/65430/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/65430/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1287987 - Record VIDEO_HIDDEN_PLAY_TIME_PERCENTAGE telemetry -

Review commit: https://reviewboard.mozilla.org/r/65432/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/65432/

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8772689 [details]
Bug 1287987 - Histogram for VIDEO_HIDDEN_PLAY_TIME_PERCENTAGE -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/65430/diff/1-2/

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8772690 [details]
Bug 1287987 - Record VIDEO_HIDDEN_PLAY_TIME_PERCENTAGE telemetry -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/65432/diff/1-2/

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8772690 [details]
Bug 1287987 - Record VIDEO_HIDDEN_PLAY_TIME_PERCENTAGE telemetry -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/65432/diff/2-3/

Comment 6

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8772690 [details]
Bug 1287987 - Record VIDEO_HIDDEN_PLAY_TIME_PERCENTAGE telemetry -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/65432/diff/3-4/

Comment 7

[u480271]

Comment on attachment 8772689 [details]
Bug 1287987 - Histogram for VIDEO_HIDDEN_PLAY_TIME_PERCENTAGE -

https://reviewboard.mozilla.org/r/65430/#review62442

LGTM

Comment 8

[u480271]

Comment on attachment 8772690 [details]
Bug 1287987 - Record VIDEO_HIDDEN_PLAY_TIME_PERCENTAGE telemetry -

https://reviewboard.mozilla.org/r/65432/#review62446

![Ship it!](https://qph.ec.quoracdn.net/main-qimg-0bf1d3de309a89d9ed70ae91f6271a7f)

Comment 9

[François Marier [:francois]]

Comment on attachment 8772689 [details]
Bug 1287987 - Histogram for VIDEO_HIDDEN_PLAY_TIME_PERCENTAGE -

https://reviewboard.mozilla.org/r/65430/#review62624

data review+

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b30a96d890b6
Histogram for VIDEO_HIDDEN_PLAY_TIME_PERCENTAGE - r=francois,kamidphish
https://hg.mozilla.org/integration/autoland/rev/3f4268be9829
Record VIDEO_HIDDEN_PLAY_TIME_PERCENTAGE telemetry - r=kamidphish

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b30a96d890b6
https://hg.mozilla.org/mozilla-central/rev/3f4268be9829