1289150 - eyedropper text color is modified when setting HTML element color value

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Julian Descottes [:jdescottes]]

Attachment: eyedropper-text-color.gif

Regression from Bug 1262439. 

Have a look at the GIF in attachment and pay attention to the color of the text below the magnifying glass.

It changes depending on the currently edited color.

STRs:
- open inspector > ruleview
- create property color: lightgrey 
- open colorpicker
- click on eyedropper icon
- move the mouse on the content page

ER: The text containing the color HEX code should be readible.
AR: The text containing the color HEX is in "lightgrey" and is hard to read.

Comment 1

[Julian Descottes [:jdescottes]]

Looks like this only happens on about:home.

On a sidenote the new eyedropper crashes on several other about: pages such as :
- about:preferences
- about:tabcrashed
- about:config

Comment 2

[Julian Descottes [:jdescottes]]

Actually this happens on any page, when you change the "color" value of the HTML element in the ruleview.

STRs:
- open inspector > ruleview
- add a new rule for the selector "html" 
- create property color: lightgrey 
- open colorpicker
- click on eyedropper icon
- move the mouse on the content page

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1289150 - prevent HTML element style color to impact highlighters;

Review commit: https://reviewboard.mozilla.org/r/69292/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69292/

Comment 4

[Julian Descottes [:jdescottes]]

Inspector bug triage, filter on CLIMBING SHOES.

Regression, but not triggered too frequently and non blocking-> P3.

Comment 5

[Julian Descottes [:jdescottes]]

Comment on attachment 8777831 [details]
Bug 1289150 - prevent HTML element style color to impact highlighters;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69292/diff/1-2/

Comment 6

[Julian Descottes [:jdescottes]]

Turns out the selector used to reset highlighter styles was too generic and could impact the content page elements (see Bug 1291306).

Moved the color reset to ":-moz-native-anonymous .eye-dropper-root"

Comment 7

[Matteo Ferretti [:zer0] [:matteo]]

(In reply to Julian Descottes [:jdescottes] from comment #6)
> Turns out the selector used to reset highlighter styles was too generic and
> could impact the content page elements (see Bug 1291306).

That's true, but why you moved? I think that having also the `color: initial` under `:-moz-native-anonymous .highlighter-container` is safe enough; and could be prevent similar bug on other highlighters. Is there a specific reason why you moved outside those rules set?

Comment 8

[Julian Descottes [:jdescottes]]

Comment on attachment 8777831 [details]
Bug 1289150 - prevent HTML element style color to impact highlighters;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69292/diff/2-3/

Comment 9

[Julian Descottes [:jdescottes]]

(In reply to Matteo Ferretti [:zer0] [:matteo] from comment #7)
> (In reply to Julian Descottes [:jdescottes] from comment #6)
> > Turns out the selector used to reset highlighter styles was too generic and
> > could impact the content page elements (see Bug 1291306).
> 
> That's true, but why you moved? I think that having also the `color:
> initial` under `:-moz-native-anonymous .highlighter-container` is safe
> enough; and could be prevent similar bug on other highlighters. Is there a
> specific reason why you moved outside those rules set?

Good point! I wrongly assumed highlighter-container was not set for the eye-dropper highlighter container. Updated the patch.

Comment 10

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 8777831 [details]
Bug 1289150 - prevent HTML element style color to impact highlighters;

https://reviewboard.mozilla.org/r/69292/#review67194

Comment 11

[Matteo Ferretti [:zer0] [:matteo]]

Thanks, Julian!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/04ecf84edcb0
prevent HTML element style color to impact highlighters;r=zer0

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/04ecf84edcb0

Comment 14

[Md. Rahimul Islam]

I have successfully reproduce this bug on firefox nightly 50.0a1 (2016-07-25)
with windows 7 (32 bit)
Mozilla/5.0 (Windows NT 6.1; rv:50.0) Gecko/20100101 Firefox/50.0

I found this fix on latest nightly 51.0a1 (2016-08-09)

Mozilla/5.0 (Windows NT 6.1; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID : 20160809030200

[bugday-20160810]