Closed
Bug 1289381
Opened 8 years ago
Closed 8 years ago
Don't fail to build sandboxing with --disable-crashreporter
Categories
(Core :: Security: Process Sandboxing, defect)
Core
Security: Process Sandboxing
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: fabrice, Assigned: fabrice)
References
Details
(Whiteboard: sbwc1)
Attachments
(1 file)
|
754 bytes,
patch
|
gcp
:
review+
|
Details | Diff | Splinter Review |
Bug 1274540 doesn't take --disable-crashreporter into account.
|
Assignee | |
Updated•8 years ago
|
Summary: Record sandboxing status in crash reports → Don't fail to build sandboxing with --disable-crashreporter
|
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8774698 -
Flags: review?(gpascutto)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8774698 [details] [diff] [review] sandbox-crashreporter.patch Review of attachment 8774698 [details] [diff] [review]: ----------------------------------------------------------------- ::: security/sandbox/linux/common/SandboxInfo.cpp @@ +287,5 @@ > { > nsAutoCString flagsString; > flagsString.AppendInt(mFlags); > > +#ifdef MOZ_CRASHREPORTER Move this to the beginning of the function, there's no point in setting up flagString if this function is a no-op. Might be worthwhile putting the whole function under the #ifdef and putting the extra #ifdef in the caller (and .h). That's a bit more work but feels cleaner to me.
Attachment #8774698 -
Flags: review?(gpascutto) → review+
Pushed by fdesre@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4ee7de477386 Don't fail to build sandboxing with --disable-crashreporter r=gcp
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4ee7de477386
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•