Closed Bug 1289381 Opened 3 years ago Closed 3 years ago

Don't fail to build sandboxing with --disable-crashreporter

Categories

(Core :: Security: Process Sandboxing, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: fabrice, Assigned: fabrice)

References

Details

(Whiteboard: sbwc1)

Attachments

(1 file)

Bug 1274540 doesn't take --disable-crashreporter into account.
Summary: Record sandboxing status in crash reports → Don't fail to build sandboxing with --disable-crashreporter
Attachment #8774698 - Flags: review?(gpascutto)
Comment on attachment 8774698 [details] [diff] [review]
sandbox-crashreporter.patch

Review of attachment 8774698 [details] [diff] [review]:
-----------------------------------------------------------------

::: security/sandbox/linux/common/SandboxInfo.cpp
@@ +287,5 @@
>  {
>    nsAutoCString flagsString;
>    flagsString.AppendInt(mFlags);
>  
> +#ifdef MOZ_CRASHREPORTER

Move this to the beginning of the function, there's no point in setting up flagString if this function is a no-op.

Might be worthwhile putting the whole function under the #ifdef and putting the extra #ifdef in the caller (and .h). That's a bit more work but feels cleaner to me.
Attachment #8774698 - Flags: review?(gpascutto) → review+
Pushed by fdesre@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ee7de477386
Don't fail to build sandboxing with --disable-crashreporter r=gcp
See Also: → 1289505
https://hg.mozilla.org/mozilla-central/rev/4ee7de477386
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.