1289573 - Update funnelcake pattern match of distributionID

Status: RESOLVED FIXED

(Cloud Services Graveyard :: Metrics: Pipeline, defect, P2)

Description

[Chris More [:cmore]]

I reviewed the code [1] that generates our retention dashboards for desktop because bug 1272776 introduces a unique pattern to the distributionID.

Funnelcakes always match this pattern:

funnelcake_pattern = re.compile("^mozilla[0-9]+$")

That's fine except for the pattern we used in bug 1272776.

The regex for funnelcake 86 ids follow:

^mozilla86(\-(values|utility)\-(new|existing)*(\-[1-6])*$

examples of valid IDs

mozilla86
mozilla86-values-new
mozilla86-utility-new
mozilla86-values-existing
mozilla86-utility-existing
mozilla86-values-new-1
...
mozilla86-values-new-6
...
mozilla86-utility-existing-1
...
mozilla86-utility-existing-6

Seems like the easiest way to handle this is to update the regex to:

funnelcake_pattern = re.compile("^mozilla[0-9]+.*$")

or

funnelcake_pattern = re.compile("^mozilla[0-9a-b\-]+$")

the first solution may be better.

[1] https://github.com/mozilla/churn-analysis/blob/master/cohort-report-telemetry/Churn.ipynb

Comment 1

[Mark Reid [:mreid]]

Attachment: Update funnelcake pattern

Comment 2

[Mark Reid [:mreid]]

r=cmore per the linked PR