128962 - [MDN] Prefs and account manager extension for return receipts

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[shliang]

Implement pref panel UI and account manager extension for MDN return receipts.

Comment 1

[shliang]

Attachment: account manager extension

Comment 2

[shliang]

Attachment: pref panel

Comment 3

[(not reading, please use [e-mail] instead)]

this blocks jefft's work for MDN.

should be landing very soon, and then shuehan will have a small patch (to add 
to 16241) to enable the UI.

nsbeta1+ and 1.0.

Comment 4

[(not reading, please use [e-mail] instead)]

r=sspitzer once you address these issues:

1) add a newline to pref-receipts.js
to fix this:
\ No newline at end of file

2) your changes to mailnews.js, do they match what jefft (or someone else?) 
suggested as the defaults?

3) 

\ No newline at end of file
for am-mdn.dtd


don't check in mailnews/base/prefs/resources/content/mailPrefsOverlay.xul, as 
that will enable the mdn pref UI in trunk builds.

after you land these files, we can then finish the build work for linux and mac.
when that's all done, we can prepare a simple patch for jefft, so he can turn 
all this code on in his tree, and then he can land your simple patch when he's 
ready to land the backend changes.

Comment 5

[shliang]

Attachment: account manager extension

Comment 6

[shliang]

Attachment: pref panel

Comment 7

[shliang]

Attachment: account manager screenshot

Comment 8

[shliang]

Attachment: pref panel screenshot

Comment 9

[shliang]

Attachment: new account manager screenshot

new screenshot - noticed checkbox labels aren't gray when disabled so fixed
that, also disabled the other labels

Comment 10

[jglick]

Looks great Shuehan, thanks. :-)

Comment 11

[(not reading, please use [e-mail] instead)]

it all looks good, except that you copied and pasted the smime CID!

using mozbot, I generated a new one.  instead of the one you are using in
mdn-service.js, use this one:

e007d92e-1dd1-11b2-a61e-dc962c9b8571

once you fix that, r/sr=sspitzer on the new files and the changes.

except, don't land any changes that will cause this UI to show up for users. 
that changes should be landed by jefft when he lands 16241

once this lands, and we've got the mac and linux build going, you can provide
jefft with small patch to turn on this UI.

Comment 12

[(not reading, please use [e-mail] instead)]

ok, I just checked in the changes necessary to get this building on linux.

note to shuehan, I also removed two files that are necessary:

mozilla/ mailnews/ extensions/ mdn/ resources/ content/ makefile.win     
mozilla/ mailnews/ extensions/ mdn/ resources/ content/ Makefile.in

I've also extended the patch for #16241 to turn on this code by default, see
that bug.

all that's left, before we can mark this fixed, is the mac build issues.

Comment 13

[(not reading, please use [e-mail] instead)]

Attachment: rename global pref to match 4.x, make certain prefs bools, not ints

Comment 14

[(not reading, please use [e-mail] instead)]

Attachment: updated patch, still testing...

Comment 15

[shliang]

Attachment: patch, for building on mac

Comment 16

[(not reading, please use [e-mail] instead)]

Attachment: fix, ready for review

Comment 17

[(not reading, please use [e-mail] instead)]

Comment on attachment 73752 [details] [diff] [review]
patch, for building on mac

sr=sspitzer

you'll want a r= from someone like sfraser or ducarroz, who build on the mac.

when we provide jefft with the patch to turn on MDN, we'll have to include a
change to mozilla/build/mac/build_scripts/MozillaBuildFlags.txt
 to set mdn to 1.

Comment 18

[shliang]

Comment on attachment 73776 [details] [diff] [review]
fix, ready for review

r=shuehan

Comment 19

[David :Bienvenu]

Comment on attachment 73776 [details] [diff] [review]
fix, ready for review

sr=bienvenu

Comment 20

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 73776 [details] [diff] [review]
fix, ready for review

a=shaver for the 1.0 trunk, with the change we discussed on IRC (default
mdn_report_enabled to false for Mozilla tree).

Comment 21

[(not reading, please use [e-mail] instead)]

fixed.

defaults to mdn off.

Comment 22

[(not reading, please use [e-mail] instead)]

Comment on attachment 73776 [details] [diff] [review]
fix, ready for review

obsolete, since it's been checked in.

I think as soon as the mac build changes go in, and we prepare one final patch
for jefft to turn on the UI, we can mark this bug fixed.

Comment 23

[Asa Dotzler [:asa]]

Comment on attachment 73776 [details] [diff] [review]
fix, ready for review

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 24

[Jean-Francois Ducarroz]

Comment on attachment 73752 [details] [diff] [review]
patch, for building on mac

good. R=ducarroz. In the case we need the define MDN_ENABLED (was in early
patch of mdn implementation), we will need to do:

+mdn		 0	 MDN_ENABLED

Comment 25

[Asa Dotzler [:asa]]

Comment on attachment 73752 [details] [diff] [review]
patch, for building on mac

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 26

[Ninoschka Baca]

Setting QA Contact to Hong since this is an enterprise feature.

Comment 27

[shliang]

fixed

Comment 28

[[e-mail] (gone - use [e-mail] instead)]

http://www.mozilla.org/mailnews/specs/receipts/

The verification is for UI-correctness and implementation on all platforms/themes.

I'm investigating with Jennifer and Robin on the wording in the prefs (both
global and per account with:

the spec says 'Move it to my Sent folder'
the implementation says 'Move it to my Sent Mail folder'

But anyways, I'll file that separately. (thanks to jglick and robinf for the
affirmation).

The actual bug for functionality is bug 16241.

Verified FIXED with:

Mac OS X 10.1.3 - 2002-04-04-11
Mandrake 8.1 - 2002-04-04-10
Mac OS 9.2.2 - 2002-04-04-10
Windows 2000 - 2002-04-05-08

Classic and Modern.