Closed Bug 1289634 Opened 3 years ago Closed 3 years ago

Enable Widevine EME and don't enable Primetime EME in default build configuration

Categories

(Core :: Audio/Video: Playback, defect, P3)

All
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox49 --- fixed
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Primetime only works in Mozilla built Firefox builds because it requires a signed plugin container. Widevine however, works in Firefox build by anyone. So we should enable Widevine by default, and but not enable Primetime, in a default build.

However, we should only download and activate the Widevine CDM on proprietary platforms (MacOSX, Windows), as users on open source platforms (i.e. Linux) have not opted in to downloading and running arbitrary binaries. We should however on Linux prompt the user the first time the CDM is requested, and ask them if they want to "enable DRM", and if they click OK, we can then download and use the CDM.

So I guess we want to add a --disable-eme={widevine,primetime} config option, and have Widevine on by default.
glandium: any comments/guidance on how we should arrange the new/existing ac_add_options here to enable Widevine and disable Adobe Primetime by default?
Flags: needinfo?(mh+mozilla)
You can just add "default='widevine'" to the existing option.
Then in our mozconfigs, you can --enable-eme=+adobe, and that should pick both. Or if you want to be more explicit, you can still do --enable-eme=adobe,widevine.
Flags: needinfo?(mh+mozilla)
(In reply to Chris Pearce (:cpearce) from comment #0)
> We should however on Linux prompt the user the first time the CDM
> is requested, and ask them if they want to "enable DRM", and if they click
> OK, we can then download and use the CDM.
Shouldn't browser.eme.ui.enabled also be set to true on linux?
(In reply to Stebs from comment #3)
> (In reply to Chris Pearce (:cpearce) from comment #0)
> > We should however on Linux prompt the user the first time the CDM
> > is requested, and ask them if they want to "enable DRM", and if they click
> > OK, we can then download and use the CDM.
> Shouldn't browser.eme.ui.enabled also be set to true on linux?

That gets enabled automatically if any CDM is enabled.
We don't want the Widevine CDM to be downloaded by default on Linux, as
the CDM is proprietary software and the user hasn't opted in to having such
software on their system. By leaving the CDM visible but disabled, we'll
prompt the user the first time EME is used, and they can approve the
download.

This means the Widevine CDM won't be downloaded by default. The user will
need to opt-in to enablding DRM playback before we'll download proprietary
CDMs.

Review commit: https://reviewboard.mozilla.org/r/69460/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69460/
Attachment #8778061 - Flags: review?(gsquelart) → review+
Comment on attachment 8778061 [details]
Bug 1289634 - Disable Widevine CDM by default on Linux, but prompt user to enable and download on first use.

https://reviewboard.mozilla.org/r/69460/#review66596
Attachment #8778059 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8778060 [details]
Bug 1289634 - Remove Widevine from Mozilla official mozconfigs, since it's enabled by default now.

https://reviewboard.mozilla.org/r/69458/#review66662
Attachment #8778060 - Flags: review?(mh+mozilla) → review+
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5eaaa9b300cc
Enable Widevine EME by default in browser builds. r=glandium
https://hg.mozilla.org/integration/autoland/rev/8425f7f24096
Remove Widevine from Mozilla official mozconfigs, since it's enabled by default now. r=glandium
https://hg.mozilla.org/integration/autoland/rev/14ff1748f948
Disable Widevine CDM by default on Linux, but prompt user to enable and download on first use. r=gerald
Comment on attachment 8778059 [details]
Bug 1289634 - Enable Widevine EME by default in browser builds.

Approval Request Comment
[Feature/regressing bug #]: Widevine EME on Linux
[User impact if declined]: Widevine EME won't be enabled or visible in the Firefox UI on Linux.
[Describe test coverage new/current, TreeHerder]: We have plenty of EME mochitests, which run on Linux.
[Risks and why]: Low; this is tweaking the build system. It'll be obvious if it's not working!
[String/UUID change made/needed]: None
Attachment #8778059 - Flags: approval-mozilla-beta?
Attachment #8778059 - Flags: approval-mozilla-aurora?
Comment on attachment 8778060 [details]
Bug 1289634 - Remove Widevine from Mozilla official mozconfigs, since it's enabled by default now.

Approval Request Comment
[Feature/regressing bug #]: Widevine EME on Linux
[User impact if declined]: Widevine EME won't be enabled or visible in the Firefox UI on Linux.
[Describe test coverage new/current, TreeHerder]: We have plenty of EME mochitests, which run on Linux.
[Risks and why]: Low; this is tweaking the build system. It'll be obvious if it's not working!
[String/UUID change made/needed]: None
Attachment #8778060 - Flags: approval-mozilla-beta?
Attachment #8778060 - Flags: approval-mozilla-aurora?
Comment on attachment 8778061 [details]
Bug 1289634 - Disable Widevine CDM by default on Linux, but prompt user to enable and download on first use.

Approval Request Comment
[Feature/regressing bug #]: Widevine EME on Linux
[User impact if declined]: Widevine EME won't be enabled or visible in the Firefox UI on Linux.
[Describe test coverage new/current, TreeHerder]: We have plenty of EME mochitests, which run on Linux.
[Risks and why]: Low; this is tweaking the build system. It'll be obvious if it's not working!
[String/UUID change made/needed]: None
Attachment #8778061 - Flags: approval-mozilla-beta?
Attachment #8778061 - Flags: approval-mozilla-aurora?
Comment on attachment 8778059 [details]
Bug 1289634 - Enable Widevine EME by default in browser builds.

Widevine EME on Linux, Aurora50+
Attachment #8778059 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8778060 [details]
Bug 1289634 - Remove Widevine from Mozilla official mozconfigs, since it's enabled by default now.

Widevine EME on Linux, Aurora50+
Attachment #8778060 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8778061 [details]
Bug 1289634 - Disable Widevine CDM by default on Linux, but prompt user to enable and download on first use.

Widevine EME on Linux, Aurora50+
Attachment #8778061 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8778059 [details]
Bug 1289634 - Enable Widevine EME by default in browser builds.

Fix the defaults and config for Widevine. OK for beta 3.
Attachment #8778059 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #8778060 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #8778061 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Depends on: 1295853
You need to log in before you can comment on or make changes to this bug.