1289723 - [e10s-multi] We need a new test for the multiple content process cases to extend browser_crashedTabs.js

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Description

[Gabor Krizsanits (INACTIVE)]

In Bug 1285941 the decision was to keep the old tests for the cases where all the tabs are from the same process and invent some new tests for the cases where the tabs are from different content processes.

Comment 1

[Will Wang [:WillWang]]

Sort this bug as ss-reliability(Bug 1330633), however could be ss-perf(Bug 1330635) as well from e10s standpoint.

Comment 2

[Will Wang [:WillWang]]

It's blocking ss-reliability, not depend.

Comment 3

[Gabor Krizsanits (INACTIVE)]

Attachment: fixing tabcrash test for multi

I think the tests Mike added for bg tabs should already cover this bug (browser_background_tab_crash.js). I've enabled multi for this test with some fixes, and I experienced an intermittent exception that can cause failures so I guarded those too.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8835396 [details] [diff] [review]
fixing tabcrash test for multi

The test changes look good to me. I'm not a peer in browser/, though, so I'm deferring that part of the review to Felipe.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/59d4978e8726
Fixing crashedTabs test for e10s-multi. r=mrbkap

Comment 6

[Carsten Book [:Tomcat]]

backed out for eslint failure like https://treeherder.mozilla.org/logviewer.html#?job_id=78995572&repo=mozilla-inbound

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8babccb56f91
Backed out changeset 59d4978e8726 for eslint failure

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2df453569f57
Fixing crashedTabs test for e10s-multi. r=mrbkap r=felipc

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2df453569f57