Closed Bug 1289723 Opened 3 years ago Closed 3 years ago

[e10s-multi] We need a new test for the multiple content process cases to extend browser_crashedTabs.js

Categories

(Firefox :: Session Restore, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 54
Iteration:
54.3 - Mar 6
Tracking Status
firefox54 --- fixed

People

(Reporter: gkrizsanits, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [e10s-multi:M1])

Attachments

(1 file)

In Bug 1285941 the decision was to keep the old tests for the cases where all the tabs are from the same process and invent some new tests for the cases where the tabs are from different content processes.
Whiteboard: [e10s-multi:?]
Whiteboard: [e10s-multi:?] → [e10s-multi:M1]
Blocks: e10s-multi-aurora
No longer blocks: 1303113
Sort this bug as ss-reliability(Bug 1330633), however could be ss-perf(Bug 1330635) as well from e10s standpoint.
Depends on: ss-reliability
It's blocking ss-reliability, not depend.
No longer depends on: ss-reliability
I think the tests Mike added for bg tabs should already cover this bug (browser_background_tab_crash.js). I've enabled multi for this test with some fixes, and I experienced an intermittent exception that can cause failures so I guarded those too.
Attachment #8835396 - Flags: review?(mrbkap)
Comment on attachment 8835396 [details] [diff] [review]
fixing tabcrash test for multi

The test changes look good to me. I'm not a peer in browser/, though, so I'm deferring that part of the review to Felipe.
Attachment #8835396 - Flags: review?(mrbkap)
Attachment #8835396 - Flags: review?(felipc)
Attachment #8835396 - Flags: review+
Attachment #8835396 - Flags: review?(felipc) → review+
Pushed by gkrizsanits@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/59d4978e8726
Fixing crashedTabs test for e10s-multi. r=mrbkap
backed out for eslint failure like https://treeherder.mozilla.org/logviewer.html#?job_id=78995572&repo=mozilla-inbound
Flags: needinfo?(gkrizsanits)
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8babccb56f91
Backed out changeset 59d4978e8726 for eslint failure
Pushed by gkrizsanits@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2df453569f57
Fixing crashedTabs test for e10s-multi. r=mrbkap r=felipc
https://hg.mozilla.org/mozilla-central/rev/2df453569f57
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Flags: needinfo?(gkrizsanits)
Iteration: --- → 54.3 - Mar 6
You need to log in before you can comment on or make changes to this bug.