New HTML Sidebar tab labels should have a font size of 11px

RESOLVED FIXED in Firefox 50

Status

defect
P1
normal
RESOLVED FIXED
3 years ago
Last year

People

(Reporter: gl, Assigned: gl)

Tracking

unspecified
Firefox 50

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(2 attachments)

The current HTML sidebar tabs' font size is 12px and does not match how it originally looks.
Assignee: nobody → gl
Status: NEW → ASSIGNED
Priority: -- → P1
Posted patch 1290003.patchSplinter Review
Attachment #8775469 - Flags: review?(hholmes)
Comment on attachment 8775469 [details] [diff] [review]
1290003.patch

Sorry, going to leave some more general "thoughts about the bug itself" than code review in here. Code changes seem fine.

Is this something we want to change back? I actually think the slightly larger font size looks quite nice. (I think we have the tendency in devtools to make things too small.)

If we were to switch things over to make them larger, where else should we change the code to make this more consistent?
Attachment #8775469 - Flags: review?(hholmes) → feedback+
(In reply to Helen V. Holmes (:helenvholmes) (:✨)(pls ni?) from comment #3)
> Comment on attachment 8775469 [details] [diff] [review]
> 1290003.patch
> 
> Sorry, going to leave some more general "thoughts about the bug itself" than
> code review in here. Code changes seem fine.
> 
> Is this something we want to change back? I actually think the slightly
> larger font size looks quite nice. (I think we have the tendency in devtools
> to make things too small.)
> 
> If we were to switch things over to make them larger, where else should we
> change the code to make this more consistent?

This is mainly a consistency problem because it is font size 11px everywhere. If we want to move to a bigger font size in the future, I would suggest we do that after FF50.
Attachment #8775469 - Flags: review?(hholmes)
Comment on attachment 8775469 [details] [diff] [review]
1290003.patch

Discussed with Gabe over IRC—while I think the new font size could be a nice enhancement, let's go with this for now and investigate bumping up font sizes post-merge.
Attachment #8775469 - Flags: review?(hholmes)
Attachment #8775469 - Flags: review+
Attachment #8775469 - Flags: feedback+
https://hg.mozilla.org/integration/fx-team/rev/ff3e8af7ce0310f278117baf8b325cbea2f4778d
Bug 1290003 - Change the HTML sidebar tab font-size to 11px r=helenvholmes DONTBUILD
https://hg.mozilla.org/mozilla-central/rev/ff3e8af7ce03
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
I would have preferred removing the font-size definition altogether, since changing it to 11px would make it look smaller than before on Windows.
Anyway, let's do this in bug 1286892.
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.