1290003 - New HTML Sidebar tab labels should have a font size of 11px

Status: RESOLVED FIXED

(DevTools :: Framework, defect, P1)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

The current HTML sidebar tabs' font size is 12px and does not match how it originally looks.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1290003.patch

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Font size for the tabs are bigger than DevEdition

Comment 3

[Helen V. Holmes (:helenvholmes) (:✨)]

Comment on attachment 8775469 [details] [diff] [review]
1290003.patch

Sorry, going to leave some more general "thoughts about the bug itself" than code review in here. Code changes seem fine.

Is this something we want to change back? I actually think the slightly larger font size looks quite nice. (I think we have the tendency in devtools to make things too small.)

If we were to switch things over to make them larger, where else should we change the code to make this more consistent?

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

(In reply to Helen V. Holmes (:helenvholmes) (:✨)(pls ni?) from comment #3)
> Comment on attachment 8775469 [details] [diff] [review]
> 1290003.patch
> 
> Sorry, going to leave some more general "thoughts about the bug itself" than
> code review in here. Code changes seem fine.
> 
> Is this something we want to change back? I actually think the slightly
> larger font size looks quite nice. (I think we have the tendency in devtools
> to make things too small.)
> 
> If we were to switch things over to make them larger, where else should we
> change the code to make this more consistent?

This is mainly a consistency problem because it is font size 11px everywhere. If we want to move to a bigger font size in the future, I would suggest we do that after FF50.

Comment 5

[Helen V. Holmes (:helenvholmes) (:✨)]

Comment on attachment 8775469 [details] [diff] [review]
1290003.patch

Discussed with Gabe over IRC—while I think the new font size could be a nice enhancement, let's go with this for now and investigate bumping up font sizes post-merge.

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

https://hg.mozilla.org/integration/fx-team/rev/ff3e8af7ce0310f278117baf8b325cbea2f4778d
Bug 1290003 - Change the HTML sidebar tab font-size to 11px r=helenvholmes DONTBUILD

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ff3e8af7ce03

Comment 8

[Tim Nguyen :ntim]

I would have preferred removing the font-size definition altogether, since changing it to 11px would make it look smaller than before on Windows.
Anyway, let's do this in bug 1286892.