1290331 - Sync is unavailable unless all the option in sync across all devices are checked

Status: VERIFIED FIXED

(Firefox for iOS :: Firefox Accounts, defect, P1)

Description

[Bingqing Li]

Firefox for iOS 5.0(2)

1. Launch Firefox for Desktop, sign in to Firefox,
2. Goto "Options -> Sync",
3. Check all the options (bookmarks, tabs, and so on) in the Sync across all devices section
4. Launch Firefox for iOS, goto "Settings", sign in to Firefox
==> Sync works fine.

5. Open Firefox for Desktop again, and goto "Options -> Sync", 
6. Remove one or two checkmarks in the Sync across all devices section( e.g. checkmark next to History/Passwords)

7. Open Firefox for iOS again, goto "Settings", tap on "Sync now"
==> Sync is unavailable.

Those users, who did not check all the options in the sync across all devices section, will be told sync is unavailable all the time without knowing why and how to fix it.

Comment 3

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/2023#attch-to-bugzilla

Hey Nick, I know :rnewman is heading on PTO next week - any chance you could take a quick peek and let me know your thoughts?

Comment 4

[Farhan Patel [:farhan]]

Comment on attachment 8775993 [details]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/2023#attch-to-bugzilla

I've left feedback. My understanding of sync is limited. Please correct me if I'm wrong :)

Comment 6

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8775993 [details]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/2023#attch-to-bugzilla

I'm about to PTO, so any f? or r? will have to come from elsewhere.

Comment 7

[Richard Newman [:rnewman]]

Comment on attachment 8775993 [details]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/2023#attch-to-bugzilla

I reviewed this. Comments on the PR.

Comment 8

[Stephan Leroux [:sleroux]]

master 36f899ec2b8308cabc7c665900fb190d5e0887cb

Comment 9

[Stephan Leroux [:sleroux]]

v5.x 199450e

Comment 10

[Simon Basca [:SimonB]]

Tested on 5.1b3 on iPhone 6 Plus.

Verifying as fixed. 

When unchecking the bookmarks and history from desktop the mentioned preferences will not be imported to mobile. When checking these preferences on desktop, sync will be performed as intended also on iOS devices.

Comment 11

[Chris]

How about when just unchecking Passwords?  That's the only thing I'm not syncing with FF Sync, and it causes the problem for me on iOS FF.

Comment 12

[Stephan Leroux [:sleroux]]

> How about when just unchecking Passwords?  That's the only thing I'm not syncing with FF Sync, and it causes the problem for me on iOS FF.

Yup this bug would appear when unchecking passwords as well. The sync actually succeeds but the messaging is not correct. Everything else will sync fine though.

Comment 13

[Chris]

Nice job fixing Sync in the 5.1 update that came out today!

Comment 14

[Simon Basca [:SimonB]]

Verifying as fix on master 0e03028ac.