1290755 - use menulist.value instead of menulist.selectedItem.getAttribute("value") in TB compose window

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[:aceman]

There are some cases in Tb compose window where we use menulist.selectedItem.getAttribute("value"). For menulist, the value should also be propagated from the selected item to the parent menulist. We should be able to fetch it from there as menulist.value. It should also be marginally faster, which may add up in loops iterating all recipients or on each key press (like Recipients2CompFields and awRecipientKeyPress).

Comment 1

[:aceman]

Attachment: patch

Comment 2

[:aceman]

Attachment: patch v2

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 8776425 [details] [diff] [review]
patch v2

As discussed, refreshed patch coming.

Comment 4

[:aceman]

Attachment: patch v3

Try run:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=4f4b3ff3048ca83da573eef41cb2ac28529ab92e

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 8777141 [details] [diff] [review]
patch v3

Review of attachment 8777141 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay and the interference with other patches/bugs.

::: mail/components/compose/content/addressingWidgetOverlay.js
@@ +598,5 @@
>        // rather than using the real visible first row of the listbox.
>        //
>        // For now we'll just put in a hack that ensures the focused attribute
>        // is never copied when the node is cloned.
> +      input[0].removeAttribute("focused");

Sorry to have rotted this hunk ;-(

Comment 6

[:aceman]

https://hg.mozilla.org/comm-central/rev/a4cb44fcfa97922b66d932b143c93002cb824a5f