use menulist.value instead of menulist.selectedItem.getAttribute("value") in TB compose window

RESOLVED FIXED in Thunderbird 51.0

Status

--
trivial
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

Trunk
Thunderbird 51.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

2 years ago
There are some cases in Tb compose window where we use menulist.selectedItem.getAttribute("value"). For menulist, the value should also be propagated from the selected item to the parent menulist. We should be able to fetch it from there as menulist.value. It should also be marginally faster, which may add up in loops iterating all recipients or on each key press (like Recipients2CompFields and awRecipientKeyPress).
(Assignee)

Comment 1

2 years ago
Created attachment 8776408 [details] [diff] [review]
patch
Attachment #8776408 - Flags: review?(mozilla)
(Assignee)

Updated

2 years ago
Attachment #8776408 - Attachment is obsolete: true
Attachment #8776408 - Flags: review?(mozilla)
(Assignee)

Comment 2

2 years ago
Created attachment 8776425 [details] [diff] [review]
patch v2
Attachment #8776425 - Flags: review?(mozilla)

Comment 3

2 years ago
Comment on attachment 8776425 [details] [diff] [review]
patch v2

As discussed, refreshed patch coming.
Attachment #8776425 - Flags: review?(mozilla)

Comment 5

2 years ago
Comment on attachment 8777141 [details] [diff] [review]
patch v3

Review of attachment 8777141 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay and the interference with other patches/bugs.

::: mail/components/compose/content/addressingWidgetOverlay.js
@@ +598,5 @@
>        // rather than using the real visible first row of the listbox.
>        //
>        // For now we'll just put in a hack that ensures the focused attribute
>        // is never copied when the node is cloned.
> +      input[0].removeAttribute("focused");

Sorry to have rotted this hunk ;-(
Attachment #8777141 - Flags: review?(mozilla) → review+
(Assignee)

Comment 6

2 years ago
https://hg.mozilla.org/comm-central/rev/a4cb44fcfa97922b66d932b143c93002cb824a5f
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 51.0
You need to log in before you can comment on or make changes to this bug.