1291269 - Wrong Lightning version in Seamonkey builds

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Frank-Rainer Grahl (:frg)]

Attachment: install.rdf.bad

The Lightning version is derived from the Thunderbird version. Starting with version 2.44 Seamonkey bundles Lightning. Unfortunately TB uses a different release schedule than Seamonkey and may have a different version number from Firefox in its config. 
Currently mail version is 47 in c-r and 49 in c-b. Lightning version should be 5.0 in c-r and 5.1 in c-b. So actually if you build suite now its 4.9 in c-r which causes problems when you upgrade Seamonkey from 2.44 to 2.45.

See install.rdf.bad which shows the wrong version information.

Its unlikely that TB will change its release schedule/version numbers  so the proposed fix is to use the Firefox version if Lightning is compiled for Seamonkey.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1291269-lightningversion.patch

Use Firefox version. Tested on c-r.

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: install.rdf.good

rdf after patch applied.

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Thunderbird's beta cycle should be following what Firefox does, and Thunderbird does not care about c-r. I wouldn't want to introduce different version dependencies between Seamonkey and Thunderbird as this would be very confusing. This is what I would expect:

comm-central: Lightning 5.3 - Firefox 51 - Thunderbird 51 - Seamonkey 2.48
 comm-aurora: Lightning 5.2 - Firefox 50 - Thunderbird 50 - Seamonkey 2.47
   comm-beta: Lightning 5.1 - Firefox 49 - Thunderbird 49 - Seamonkey 2.46
comm-release: Lightning 5.0 - Firefox 48 -     ---        - Seamonkey 2.45

If the mail version in c-r is 47, then this sounds to me like the merge is not quite correct.

Patrick, can you confirm these versions are correct and the merge to c-r went well?
Wayne, can you confirm the versions of Thunderbird are as expected?

Comment 4

[Frank-Rainer Grahl (:frg)]

Attachment: version.jpg

I always thought it was intentional because of the different release schedule and didn't cause any problems prior to Seamonkey 2.44 FF 47. 

Previously was the same with FF 45 and 46:

https://hg.mozilla.org/releases/comm-beta/rev/3cfba17974fc

Comment 5

[Patrick Cloke [:clokep]]

Attachment: Check versions of mail/suite in comm-* repos

Philipp, as far as I know the merge went fine! The version of Thunderbird in release does seem wonky, but as far as I know everything went fine.

comm-central: Thunderbird 51.0a1 - Seamonkey 2.48a1
 comm-aurora: Thunderbird 50.0a2 - Seamonkey 2.47a2
   comm-beta: Thunderbird 49.0   - Seamonkey 2.46  
comm-release: Thunderbird 47.0   - Seamonkey 2.45  

I know ewong had questions about the comm-release merge last merge cycle that I'm not sure we ever cleared up. It's possible something is messed up in that repo.

Doesn't look like it was from the merge but from an "automated version bump" which reset 48 to 47:
http://hg.mozilla.org/releases/comm-release/rev/1b8232f11137

I'm not sure what that's from, probably something to do with releasing betas.

Please let me know if you have more questions!

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8776926 [details] [diff] [review]
1291269-lightningversion.patch

We did do a few late betas after merges, which is why the version may have gotten messed up. Since this was meant to be an exception, I'd suggest to just fix the Thunderbird version on c-r to Thunderbird 48.

If you create a patch for it, please r? :wsmwk.

Comment 7

[Frank-Rainer Grahl (:frg)]

Attachment: 1291269-mailversion.patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: Lightning is build with the wrong version number which results in upgrade problems for Seamonkey users.
Testing completed (on c-c, etc.): c-r
Risk to taking this patch (and alternatives if risky): none because TB doesn't use c-r

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 8777795 [details] [diff] [review]
1291269-mailversion.patch

LGTM based on comment 6

Comment 9

[Frank-Rainer Grahl (:frg)]

Wayne, can you also give me the c-r approval?

Thanks
FRG

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 8777795 [details] [diff] [review]
1291269-mailversion.patch

I don't have approval authority. It's just a text change I know. But better someone else approve - maybe cloke?

(Or review authority for that matter - although the review was trivial)

Comment 11

[Frank-Rainer Grahl (:frg)]

Patrick,

can you give me the approval for c-r?

FRG

Comment 12

[Patrick Cloke [:clokep]]

Comment on attachment 8777795 [details] [diff] [review]
1291269-mailversion.patch

Review of attachment 8777795 [details] [diff] [review]:
-----------------------------------------------------------------

I don't have the right flags to do that, but a=me

Comment 13

[Frank-Rainer Grahl (:frg)]

Fixed. Thanks.

https://hg.mozilla.org/releases/comm-release/rev/22f02b328e4a