1291370 - [geckoview] Add Fennec-and-GeckoView Task Cluster job building using --with-gradle

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[Nick Alexander :nalexander [he/him]]

On day one, it's reasonable to ride GeckoView AAR production
along-side Fennec artifact production.  However, we don't currently
have a TC job building (and testing!) Fennec using --with-gradle, and
--with-gradle is essential for building GeckoView.  This ticket tracks
adding such a job.

jlund just ported all Fennec builds and test to run in TC; I expect
cloning that job and tweaking the mozconfig to Just Work, possibly
with follow-ups to handle ProGuard, unexpected test failures, etc.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1291370 - Add Fennec-and-GeckoView Task Cluster job building using --with-gradle.

Review commit: https://reviewboard.mozilla.org/r/68762/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68762/

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8777148 [details]
Bug 1291370 - Add Fennec-and-GeckoView Task Cluster job building using --with-gradle.

Sorry dustin -- pushed wrong patch to review.

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8777148 [details]
Bug 1291370 - Add Fennec-and-GeckoView Task Cluster job building using --with-gradle.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/68762/diff/1-2/

Comment 4

[Nick Alexander :nalexander [he/him]]

dustin: consider that r? more of an f?, 'cuz I need help.  It doesn't actually trigger the tests like I want:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b65b04b4da1

has only a handful of tests (why?), and

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4244fed90395

has no tests at all!  The decision tasks appear to queue lots of test jobs, but they don't actually appear.

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

The issues you're seeing appear to be related to treeherder not reporting job status.  The decision task is, indeed, queueing the jobs, and if you inspect those taskIds, they are completed successfully...

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8777148 [details]
Bug 1291370 - Add Fennec-and-GeckoView Task Cluster job building using --with-gradle.

https://reviewboard.mozilla.org/r/68762/#review66056

Comment 7

[Nick Alexander :nalexander [he/him]]

gbrown: TH is busted (garndt and camd are on it), but this appears to be working: https://tools.taskcluster.net/task-group-inspector/#PjaFt0T3TwS2ERtQoYzkPQ/.

However, turning this on will double (or 3/2) the number of Android test jobs we schedule, since they'll all run for the Tier 2 B without --with-gradle and (after this patch) for the Tier 2 B with --with-gradle.

That seems like a lot of expense.  It's extremely unlikely we'd witness differences in platform tests (like reftest, or Mochitest) when running with Gradle.  Perhaps I should restrict to just Robocop and Android-specific tests?  That's where we'd see differences, I think -- in resource packaging, or library locations, or omni.ja packaging.

What do you think?

Comment 8

[Geoff Brown [:gbrown]]

I agree that running all the tests seems like too much. Robocop sounds right to me. mochitest-chrome also comes to mind, for the mobile/android/tests/browser/chrome tests. But I think Robocop-only is the place to start.

I understand Myk may introduce a new test harness for GeckoView down the road, which would presumably add more coverage of gradle-built things.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/bade2af0597b
Add Fennec-and-GeckoView Task Cluster job building using --with-gradle. r=dustin,gbrown

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bade2af0597b