1291500 - Cannot move cZ tabs by drag&drop anymore

Status: VERIFIED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Tony Mechelynck [:tonymec]]

Using ChatZilla 0.9.92.2016033013

Affects SeaMonkey 2.47a1 (Gecko/Toolkit 50.0a1) since 14 July and maybe a couple of days before that
Affects all builds of SeaMonkey 2.48a1 (Gecko/Toolkit 51.0a1) so far
Seen on (at least) Linux64 (seen by me) and Windows (seen by frg)
Does not affect SeaMonkey 2.46 (Gecko/Toolkit 49.0)

I suspect some API used by cZ was removed but I can't be sure. If it isn't that, the bug may have to be moved to some other Product/Component.

I haven't yet tried it on Firefox yet, but after reporting this I will.

Bug happens regardless of:
- userChrome.css (tested with 2 versions and with none)
- complete theme (tested with EarlyBlue and with Default)

It is not possible anymore to move ChatZilla tabs by drag&drop (no effect: the tab stays put, the mouse pointer doesn't change -doesn't become "moving object" pointer- but the mousedown intended for drag does select the tab).
(Browser tabs can still be drag-dropped)

P.S. The reason I think it happened on 14 July or shortly before is that there were a couple of new builds of the EarlyBlue theme around that date, and that I mistakenly thought they were the source of the problem.

My current SeaMonkey build is as follows but as said above I've been seeing this for a little over 2 weeks:

User agent: Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0 SeaMonkey/2.48a1
Build identifier: 20160802003002
http://hg.mozilla.org/mozilla-central/rev/ffac2798999c5b84f1b4605a1280994bb665a406
http://hg.mozilla.org/comm-central/rev/01f5f751c3aa

Comment 1

[Tony Mechelynck [:tonymec]]

Doesn't work either (with the same cZ version) in Firefox:

UA:"Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0"
ID:20160802030437
mozilla-central changeset ffac2798999c5b84f1b4605a1280994bb665a406

Now I'll try to find the "last good" and "first bad" nightlies.

Comment 2

[Tony Mechelynck [:tonymec]]

Testing with Firefox because I have a lighter profile

July 12 is GOOD
https://hg.mozilla.org/mozilla-central/rev/aac8ff1024c553d9c92b85b8b6ba90f65de2ed08

July 13 is BAD
https://hg.mozilla.org/mozilla-central/rev/04821a70c739a00d12e12df651c0989441e22728

Comment 3

[Tony Mechelynck [:tonymec]]

There seems to be rather few bugs in range
https://hg.mozilla.org/mozilla-central/log?rev=04821a70c739a00d12e12df651c0989441e22728%3Aaac8ff1024c553d9c92b85b8b6ba90f65de2ed08

Bug 1284372 (access denied)
Bug 1279703 in Firefox :: Developer Tools: Computer Styles Inspector
Bug 1285157 in Firefox OS :: General
Bug 1283785 in Core :: Audio/Video: Playback
Bug 1283783 in Core :: Audio/Video: Playback
Bug 1276573 in Core :: MFBT
Bug 1278748 in Core :: Audio/Video: Playback
Bug 1283769 in Core :: Audio/Video: Playback

Note that audio/video bug 1283785 "removes some unused functions and macros". This sounds suggestive to me; however an audio/video bugfix ought not to affect ChatZilla.

Comment 4

[Edmund Wong (:ewong)]

(In reply to Tony Mechelynck [:tonymec] from comment #3)
> There seems to be rather few bugs in range
> https://hg.mozilla.org/mozilla-central/
> log?rev=04821a70c739a00d12e12df651c0989441e22728%3Aaac8ff1024c553d9c92b85b8b6
> ba90f65de2ed08
> 
> Bug 1284372 (access denied)
> Bug 1279703 in Firefox :: Developer Tools: Computer Styles Inspector
> Bug 1285157 in Firefox OS :: General
> Bug 1283785 in Core :: Audio/Video: Playback
> Bug 1283783 in Core :: Audio/Video: Playback
> Bug 1276573 in Core :: MFBT
> Bug 1278748 in Core :: Audio/Video: Playback
> Bug 1283769 in Core :: Audio/Video: Playback
> 
> Note that audio/video bug 1283785 "removes some unused functions and
> macros". This sounds suggestive to me; however an audio/video bugfix ought
> not to affect ChatZilla.

could this be related to bug 1162050?

Comment 5

[Tony Mechelynck [:tonymec]]

(In reply to Edmund Wong (:ewong) from comment #4)
> (In reply to Tony Mechelynck [:tonymec] from comment #3)
> > There seems to be rather few bugs in range
> > https://hg.mozilla.org/mozilla-central/
> > log?rev=04821a70c739a00d12e12df651c0989441e22728%3Aaac8ff1024c553d9c92b85b8b6
> > ba90f65de2ed08
> > 
> > Bug 1284372 (access denied)
> > Bug 1279703 in Firefox :: Developer Tools: Computer Styles Inspector
> > Bug 1285157 in Firefox OS :: General
> > Bug 1283785 in Core :: Audio/Video: Playback
> > Bug 1283783 in Core :: Audio/Video: Playback
> > Bug 1276573 in Core :: MFBT
> > Bug 1278748 in Core :: Audio/Video: Playback
> > Bug 1283769 in Core :: Audio/Video: Playback
> > 
> > Note that audio/video bug 1283785 "removes some unused functions and
> > macros". This sounds suggestive to me; however an audio/video bugfix ought
> > not to affect ChatZilla.
> 
> could this be related to bug 1162050?

Could be. This bug is not mention in the straight log linked to in comment #3 but the longer log (with merged-in changesets) at http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=aac8ff1024c553d9c92b85b8b6ba90f65de2ed08&tochange=04821a70c739a00d12e12df651c0989441e22728 has it.

Comment 6

[Tony Mechelynck [:tonymec]]

I suppose there's no chance of having the Core guys backout their "fix" because it breaks ChatZilla, even ChatZilla-in-Firefox?

Comment 7

[Tony Mechelynck [:tonymec]]

Well let's assume we found the culprit. (We can always change it later if we find a better suspect.) So how can we make drag&drop work again?

Comment 8

[Philip Chee]

(In reply to Tony Mechelynck [:tonymec] from comment #7)
> Well let's assume we found the culprit. (We can always change it later if we
> find a better suspect.) So how can we make drag&drop work again?
Maybe find some helpful hints here: https://hg.mozilla.org/comm-central/rev/8af06972e213

Comment 9

[Frank-Rainer Grahl (:frg)]

Just changing the literals doesn't seem to work or its not picking up the nsdragdrop.js from suite\mailnews. But don't see an exception so something else might be missing.

Comment 10

[Frank-Rainer Grahl (:frg)]

Attachment: 1291500-dragdrop.patch

>> Just changing the literals doesn't seem to work 

pebkac don't ask... Works with Seamonkey 2.48a1.

Can someone test it with Firefox Nightly. Not sure if nsDragAndDrop.js need to change there.

Comment 11

[James Ross]

Comment on attachment 8777426 [details] [diff] [review]
1291500-dragdrop.patch

Ah, good ol' surprise API removal. I especially like the way nsDragAndDrop.js is being added back everywhere. (I guess we probably *should* look to replace it, though.)

Anyhow, this patch looks quite sane; my understanding is that the new event names (ondragstart and ondrop) have been around for long enough that we don't need to care about back-compact - we only care about the latest Firefox and ESR versions.

I'd give you r+ apart from the version changes; we only change the locale versions when the locale file changes, and only change the core version when making a release. Otherwise, looks good!

Comment 12

[Frank-Rainer Grahl (:frg)]

Attachment: 1291500-dragdrop-V2.patch

Oki. I verified that the nsDragAndDrop.js in the xpi is actually used even in Seamonkey where a global one is still around so it should work in Firefox and elsewhere.

Comment 13

[James Ross]

Comment on attachment 8777572 [details] [diff] [review]
1291500-dragdrop-V2.patch

Review of attachment 8777572 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thanks!

Comment 14

[Frank-Rainer Grahl (:frg)]

Done.
https://hg.mozilla.org/chatzilla/rev/2deb3332502b

Also moved up the tag for Seamonkey.
https://hg.mozilla.org/chatzilla/rev/d5239c42cbf1

Comment 15

[Tony Mechelynck [:tonymec]]

As soon as I see either a new cZ nightly at http://james-ross.co.uk/mozilla/chatzilla/nightly/builds/0.9.92/ or a SeaMonkey built later than comment #14 (and the ChatZilla that comes with it) I'll test that in both Sm 2.48a1 and Fx 51.0a1 and report here.

Comment 16

[Tony Mechelynck [:tonymec]]

After installing the new ChatZilla 0.9.92.2016080411 nightly:

WORKS in SeaMonkey
User agent: Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0 SeaMonkey/2.48a1
Build identifier: 20160804003002
http://hg.mozilla.org/mozilla-central/rev/1576e7bc1bec7232e9e4ba78cce62526b1a6380b
http://hg.mozilla.org/comm-central/rev/3a89a3a4d410

WORKS in Firefox
Build identifier: Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0
20160803030226
https://hg.mozilla.org/mozilla-central/rev/6608e5864780589b25d5421c3d3673ab30c4c318

=> VERIFIED

Comment 17

[Tony Mechelynck [:tonymec]]

Release note: The fixed version of ChatZilla won't install spontaneously into existing profiles, even in SeaMonkey with which it is distributed. Existing users will have to do one of the following:
* manually install http://james-ross.co.uk/mozilla/chatzilla/nightly/builds/0.9.92/2016080411/chatzilla-0.9.92-2016080411.xpi or later;
* in SeaMonkey 2.48a1 or 2.47a2 later than comment #14: manually install <installdir>/distribution/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}.xpi into the profile by "Install Add-ons from File..." in about:addons
* wait for a new version, strictly later than 0.9.92, to appear at AMO. Only then will the Add-ons Manager become conscious that an upgrade is needed.