1292097 - Dropping new recipients into address widget is very slow

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[:aceman]

+++ This bug was initially created as a clone of Bug #1290729 +++

Dragging many recipients (e.g. from the Contacts sidebar) is slow (tens of seconds for hundreds of recipients), similar to adding them via "Add to To" was before bug 1290729.

Analysis:
AutomatedAutoCompleteHandler.processAllResults() is the last user of awAddRecipient() - the non-batched adding of each recipient individually.

That is not optimal as AutomatedAutoCompleteHandler has knowledge of the whole batch (array) that it needs to process, it just chooses to append them one by one to the recipient box.

I think we can convert it to awAddRecipientArray() easily.

Comment 1

[:aceman]

Attachment: patch

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 8777973 [details] [diff] [review]
patch

Review of attachment 8777973 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good. I tested by dragging a few recipients from the side panel and the address book. Works as before (which is expected from a refactoring). Since there is only one new comment, I didn't find any nits to pick ;-)
r=jorgk.

Comment 3

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/800c3114b6f8