1292133 - Inspect element action does not work correctly while RDM is enabled

Status: VERIFIED FIXED

(DevTools :: Responsive Design Mode, defect, P1)

Description

[Mihai Boldan, Desktop QA [:mboldan]]

Attachment: inspect element.mov

[Affected versions]:
- Firefox 51.0a1 (2016-08-03)

[Affected platforms]:
- Windows 10 x64, Mac OS X 10.11.1, Ubuntu 16.04 x64

[Steps to reproduce]:
1. Launch Firefox.
2. From about:config, enable the devtools.responsive.html.enabled pref.
3. Open RDM.
4. Enable Toggle tools.
5. Right click on an element from the page and select the 'Inspect Element' option.

[Expected result]:
- The details of the selected element are displayed in the Inspector.

[Actual result]:
- The inspected element is not selected in the HTML tree (see the attached screencast). 

[Regression range]:
- This is not a regression.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1dea884b7a7c

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1292133 - Add contextmenu tunnelling for inspect element.

Review commit: https://reviewboard.mozilla.org/r/74584/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74584/

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

This work depends on the change in bug 1297569, so you'll need to apply that patch as well (if you want to test during review).

Comment 4

[Alexandre Poirot [:ochameau]]

Comment on attachment 8785343 [details]
Bug 1292133 - Add contextmenu tunnelling for inspect element.

https://reviewboard.mozilla.org/r/74584/#review72788

I really appreciate such patch to review after having to review patches to like bug 1297362 ;)

Note that Inspect element still appear when right clicking within RDM document and fails with "Permission denied to access property "ownerDocument""
you might want to disable the context menu entry or something?

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8785343 [details]
Bug 1292133 - Add contextmenu tunnelling for inspect element.

https://reviewboard.mozilla.org/r/74584/#review72788

> Note that Inspect element still appear when right clicking within RDM document and fails with "Permission denied to access property "ownerDocument""
you might want to disable the context menu entry or something?

Hmm, thanks for pointing this out!  I think I'll defer this to bug 1278762 (the more general "context menu doesn't really work" bug).  There isn't really a simple way to disable just this one item in this specific context.  Over in that bug, I might make my own context menu with just the few things that work...?  Unsure so far.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f91a4cdf2718
Add contextmenu tunnelling for inspect element. r=ochameau

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f91a4cdf2718

Comment 8

[Mihai Boldan, Desktop QA [:mboldan]]

The issue is no longer reproducible on Firefox 51.0a1 (2016-09-13), using the STR from Comment 0.
The tests were performed under Windows 10x64, Mac OS X 10.11.1 and under Ubuntu 16.04x64.
I am marking this issue Verified Fixed.