1297569 - Disable XUL popup contextmenu handler for all remote targets

Status: RESOLVED FIXED

(Core :: XUL, defect, P1)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

In bug 516753, nsXULPopupListener.cpp was modified to abort contextmenu event handling if the event target is content inside a remote xul:browser.

On the DevTools team, we are working on a new Responsive Design Mode tool which uses an <iframe mozbrowser remote> element to display content.

Currently, this XUL popup listener is grabbing contextmenu events before the remote content can process them.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1297569 - Disable XUL popup contextmenu handler for all remote targets.

This expands the existing escape hatch added by bug 516753 (which disabled this
same handler for content within a remote xul:browser).  After this change, it is
is disabled for any remote target (`EventStateManager::IsRemoteTarget`), which
in practice means remote xul:browser or remote iframe mozbrowser.

Review commit: https://reviewboard.mozilla.org/r/73742/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73742/

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8784201 [details]
Bug 1297569 - Disable XUL popup contextmenu handler for all remote targets.

https://reviewboard.mozilla.org/r/73742/#review72234

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1dea884b7a7c

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b1c1291f1f67
Disable XUL popup contextmenu handler for all remote targets. r=felipe

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b1c1291f1f67