1292392 - Clean up SurfaceCache now that the move over to ISurfaceProviders is complete

Status: RESOLVED INACTIVE

(Core :: Graphics: ImageLib, defect)

Description

[Seth Fowler [:seth] [:s2h]]

There has been a lot of refactoring lately in SurfaceCache-related code, including the move to ISurfaceProviders that brought with it a change to the way placeholders work. Now that that refactoring is complete, it's time to clean up the SurfaceCache code, remove old concepts, and take advantages of the changes to make things a little safer (in particularly by taking advantage of NotNull<T>).

Comment 1

[Daniel Holbert [:dholbert]]

Looks like bug 1296762 covers some of the work here (e.g. its "part 1" removes a comment that referred to this bug, "The old mechanism will be removed in bug 1292392" -- and its later parts take advantage of NotNull).

Should these bugs be merged/duped in some way? Or, is there more that should happen on this bug, distinct from bug 1296762?

Comment 2

[Daniel Holbert [:dholbert]]

(maybe this bug wants to be a metabug with several code-cleanup dependencies?)

Comment 3

[Seth Fowler [:seth] [:s2h]]

Yeah, the work that was going to happen in this bug ended up needing to be split into several smaller bugs. I've added them as dependencies.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:aosmond, could you have a look please?
For more information, please visit auto_nag documentation.