Open Bug 1292392 Opened 3 years ago Updated 3 years ago

Clean up SurfaceCache now that the move over to ISurfaceProviders is complete

Categories

(Core :: ImageLib, defect)

defect
Not set

Tracking

()

People

(Reporter: seth, Assigned: seth)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

There has been a lot of refactoring lately in SurfaceCache-related code, including the move to ISurfaceProviders that brought with it a change to the way placeholders work. Now that that refactoring is complete, it's time to clean up the SurfaceCache code, remove old concepts, and take advantages of the changes to make things a little safer (in particularly by taking advantage of NotNull<T>).
Blocks: 1228704
Looks like bug 1296762 covers some of the work here (e.g. its "part 1" removes a comment that referred to this bug, "The old mechanism will be removed in bug 1292392" -- and its later parts take advantage of NotNull).

Should these bugs be merged/duped in some way? Or, is there more that should happen on this bug, distinct from bug 1296762?
Flags: needinfo?(seth.bugzilla)
(maybe this bug wants to be a metabug with several code-cleanup dependencies?)
Yeah, the work that was going to happen in this bug ended up needing to be split into several smaller bugs. I've added them as dependencies.
Depends on: 1296762, 1298544
Flags: needinfo?(seth.bugzilla)
You need to log in before you can comment on or make changes to this bug.