1292585 - Media control notification is out of sync

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Audio/Video, defect, P1)

Description

[Sorina Florean [:sflorean]]

Environment: 
Device: LG G4 (Android 5.1);
Build: Nightly 51.0a1 (2016-08-04);

Steps to reproduce:
1. On Nightly, go to youtube.com and play a video;
2. Open tab 2 and play a different video;
3. Open notification bar.

Expected result:
A notification is displayed with page title, URL, play/pause button and favicon from video open in tab 2.

Actual result:
A notification is displayed with page title, URL, play/pause button and favicon from video open in first tab.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1292585 - only update reference tab when tab starts playing.

Review commit: https://reviewboard.mozilla.org/r/69924/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69924/

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1292585 - part2 : add log.

Review commit: https://reviewboard.mozilla.org/r/69926/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69926/

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8778761 [details]
Bug 1292585 - only update reference tab when tab starts playing.

https://reviewboard.mozilla.org/r/69924/#review67170

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8778762 [details]
Bug 1292585 - part2 : add log.

https://reviewboard.mozilla.org/r/69926/#review67172

Not sure if we need to land the log statements for everyone?

::: mobile/android/base/java/org/mozilla/gecko/media/MediaControlService.java:106
(Diff revision 1)
>      public void onTabChanged(Tab tab, Tabs.TabEvents msg, String data) {
>          if (!mIsInitMediaSession) {
>              return;
>          }
>  
> +        Log.d(LOGTAG, "OnTabChanged, msg = " + msg + ", tab = " + tab);

Do we need to land this or is it just for debugging? This will be called for every tab event; maybe that's a bit too much?

Comment 5

[Alastor Wu [:alwu]]

(In reply to Sebastian Kaspari (:sebastian) from comment #4)
> Do we need to land this or is it just for debugging? This will be called for
> every tab event; maybe that's a bit too much?

Oh, I didn't consider about that, we can only land patch 1 if this patch is too heavy.

Comment 6

[Alastor Wu [:alwu]]

Comment on attachment 8778761 [details]
Bug 1292585 - only update reference tab when tab starts playing.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69924/diff/1-2/

Comment 7

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ff350086900a&selectedJob=25264864

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ccdde7dc5d72
only update reference tab when tab starts playing. r=sebastian

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ccdde7dc5d72

Comment 10

[Sorina Florean [:sflorean]]

Verified as fixed:
Device: Nexus 5 (Android 6.0.1) and LG G4 (Android 5.1)
Build: Nightly 51.0a1 (2016-08-10)