1290836 - Re-enable media control for all versions (Remove nightly flag)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Audio/Video, defect)

Description

[Alastor Wu [:alwu]]

Fork from bug1290510, we would re-enable media control for all versions when it's more stable and ready to be shipped.

Comment 1

[Alastor Wu [:alwu]]

This bug would be landed after fixing bug1290467. 
I ask for a review now just because I want to reduce reviewing process time and make sure it can be landed immediately after bug1290467.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1290836 - Re-enable media control for all versions.

Review commit: https://reviewboard.mozilla.org/r/76706/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/76706/

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8788123 [details]
Bug 1290836 - Re-enable media control for all versions.

Maybe let's wait after Bug 1290467 lands (I'm just building, testing and reviewing the patch!) - then let's see how it behaves in Nightly and if there are any more issues. With merge day next week let's target 52.

Comment 4

[Sorina Florean [:sflorean]]

Hi, 
Here is the doc sheet with test cases and results: https://docs.google.com/spreadsheets/d/17HbRS8EHayb5G8dwOFcVj7CMjbXq-uMmg0T_H8qbEFU/edit#gid=0. From my side I'm agree with comment 3 because needs more testing after bug 1290467 lands (maybe new test cases).  
Thanks!

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8788123 [details]
Bug 1290836 - Re-enable media control for all versions.

Snorp, Brad: All linked bugs are fixed now and in today's Nightly. We are thinking about letting the feature ride the trains with 52. You have both been reporting problems in the past. Please let us know if you are seeing any issues in Nightly that should block the feature.

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8788123 [details]
Bug 1290836 - Re-enable media control for all versions.

https://reviewboard.mozilla.org/r/76706/#review76308

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 8788123 [details]
Bug 1290836 - Re-enable media control for all versions.

The last couple patches landed at the end of last week. I'm all for the plan to ship this in 52, but IMO the right thing to do is to check in mid-nightly cycle and see how the feature is looking and at that point if things look good remove the nightly block.

The other thing I'd note is at this point most nightly testers have it in their heads "this feature is broken and not riding the trains." In order to validate that it is ready to ride the trains you need to reset that mindset. Normally I'd suggest an announcement at the mobile stand up, but we don't have those anymore. Perhaps an email to the nightly-testers list would be the next best thing.

Comment 8

[Alastor Wu [:alwu]]

Comment on attachment 8788123 [details]
Bug 1290836 - Re-enable media control for all versions.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/76706/diff/1-2/

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

@sorina: All linked bugs are now fixed. Do you recommend doing another round of testing before letting this ride the trains?

Comment 10

[Sorina Florean [:sflorean]]

(In reply to Sebastian Kaspari (:sebastian) from comment #9)
> @sorina: All linked bugs are now fixed. Do you recommend doing another round
> of testing before letting this ride the trains?

Hi,
The feature looks stable now and the testing process will continue after this ride the trains. 
I will like to test again today, on different devices, and if is no majors issues, this can land.

Comment 11

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8788123 [details]
Bug 1290836 - Re-enable media control for all versions.

https://reviewboard.mozilla.org/r/76706/#review89712

From the mail:
> Recommendation from QE: SHIP IT.

Let's go! :)

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be91d38389a5
Re-enable media control for all versions. r=sebastian,snorp

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/be91d38389a5

Comment 14

[Sorina Florean [:sflorean]]

Verified as fixed in build 52.0a2 (2016-12-11);
Device: Nexus 5 (Android 6.0.1).