1292995 - Replace in-tree consumer of non-standard Iterator() with Object.{values,entries} in services/

Status: RESOLVED FIXED

(Cloud Services :: General, defect)

Description

[Tooru Fujisawa [:arai]]

separated from bug 1290637.
see bug 1290637 for the details.

Required code changes are following:
  * Check each usage of non-standard Iterator [1] function,
    and replace it with Object.entries [2] or Object.values [3],
    or something appropriate for the specific usage

Here's the rough list for Iterator() usage (not exhaustive)
https://dxr.mozilla.org/mozilla-central/search?q=%22+Iterator(%22+path%3Aservices%2F&redirect=false

for example:
  for (let [k, v] in Iterator(obj)) {
    ...
  }
can be replaced to:
  for (let [k, v] of Object.entries(obj)) {
    ...
  }

another example:
  for (let [, v] in Iterator(array)) {
    ...
  }
can be replaced to:
  for (let v of array) {
    ...
  }


[1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Iterator
[2] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/entries
[3] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/values

Comment 1

[Sumit Tiwari]

Attachment: Bug 1292995 - Replace Iterator() with Object.{values,entries} in services/;

Review commit: https://reviewboard.mozilla.org/r/70186/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/70186/

Comment 2

[Sumit Tiwari]

All tests in the services/ folder passed, so hopefully this changeset won't have the same mistakes as the one for bug 1290698.

Comment 3

[Tooru Fujisawa [:arai]]

Comment on attachment 8779154 [details]
Bug 1292995 - Replace Iterator() with Object.{values,entries} in services/;

https://reviewboard.mozilla.org/r/70186/#review67512

Thank you for taking this :)

Looks good.
forwarding to gps, as I'm not module owner/peer here.

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8779154 [details]
Bug 1292995 - Replace Iterator() with Object.{values,entries} in services/;

https://reviewboard.mozilla.org/r/70186/#review67700

Comment 5

[Tooru Fujisawa [:arai]]

Thanks!

here's try run
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e44fe871b9b1

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7bab284d7910
Replace Iterator() with Object.{values,entries} in services/; r=gps

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7bab284d7910