1290637 - Replace in-tree consumer of non-standard Iterator() with Object.{values,entries}

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tooru Fujisawa [:arai]]

Now Object.values and Object.entries are in tree, and we could replace most of Iterator() call with them, if it's iterating over simple object properties.

not-exhaustive list of possible comsumers:
https://dxr.mozilla.org/mozilla-central/search?q=%22in+Iterator(%22&redirect=false

Comment 1

[Tooru Fujisawa [:arai]]

This may match some more usage:
https://dxr.mozilla.org/mozilla-central/search?q=%22+Iterator(%22&redirect=true

Also, here are links for documentation
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Iterator
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/entries
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/values

Comment 2

[Tooru Fujisawa [:arai]]

Required code changes are following:
  * Check each usage of non-standard Iterator function,
    and replace it with Object.entries or Object.values,
    or something appropriate for the specific usage

Comment 3

[Tooru Fujisawa [:arai]]

I'm going to make this a meta bug.

Comment 4

[Aman Mehta]

I want to take up this bug, I am a newbie please guide me.

Comment 5

[Tooru Fujisawa [:arai]]

This is a meta bug to track depending bugs.
currently the following 4 bugs are not assigned:
  * bug 1293004
  * bug 1293005
  * bug 1293006
  * bug 1293008

Comment 6

[Aman Dwivedi]

Hello! I would like to take this up. Can you please assign it to me? :)

Comment 7

[Tooru Fujisawa [:arai]]

This is a metabug, and this will be fixed when all depending bugs are fixed.
nothing should be done here.

Comment 8

[Aman Dwivedi]

So, Can we look at it after the other depending bugs are fixed? or no need to look at this at all?

Comment 9

[Tooru Fujisawa [:arai]]

I'll just close this bug when all depending bugs are fixed.
everything should be done for Iterator is separated into each depending bugs, for each directory.

Comment 10

[Mark Banner (:standard8)]

I've just been looking at some no-undef issues from eslint. It looks like there's quite a few places where StopIteration is still used and possibly expected to be valid, even though the code has changed:

https://dxr.mozilla.org/mozilla-central/search?q=StopIteration+file%3A*.js&redirect=false

Not sure if that should be included in this bug, or needs a separate one.

Comment 11

[Tooru Fujisawa [:arai]]

(In reply to Mark Banner (:standard8) from comment #10)
> I've just been looking at some no-undef issues from eslint. It looks like
> there's quite a few places where StopIteration is still used and possibly
> expected to be valid, even though the code has changed:
> 
> https://dxr.mozilla.org/mozilla-central/search?q=StopIteration+file%3A*.
> js&redirect=false
> 
> Not sure if that should be included in this bug, or needs a separate one.

Thanks!
StopIteration is part of legacy generator, that should be handled in bug 968038 and depending bugs.
All already-resolved bugs there have targeted on legacy generator itself, so there will be several overlooked StopIteration references.
Might be better waiting for remaining legacy generator consumers to be removed, before removing StopIteration.