1293004 - Replace in-tree consumer of non-standard Iterator() with Object.{values,entries} in chat/ in comm-central

Status: RESOLVED FIXED

(Chat Core :: General, defect)

Description

[Tooru Fujisawa [:arai]]

separated from bug 1290637.
see bug 1290637 for the details.

Required code changes are following:
  * Check each usage of non-standard Iterator [1] function,
    and replace it with Object.entries [2] or Object.values [3],
    or something appropriate for the specific usage

Here's the rough list for Iterator() usage (not exhaustive)
https://dxr.mozilla.org/comm-central/search?q=%22+Iterator(%22+path%3Achat%2F&redirect=false

for example:
  for (let [k, v] in Iterator(obj)) {
    ...
  }
can be replaced to:
  for (let [k, v] of Object.entries(obj)) {
    ...
  }

another example:
  for (let [, v] in Iterator(array)) {
    ...
  }
can be replaced to:
  for (let v of array) {
    ...
  }


[1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Iterator
[2] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/entries
[3] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/values

Comment 1

[Aman Mehta]

If this is a good first-timer's bug, I would like to take this bug. Can you guide me further?
Thanks.

Comment 2

[Tooru Fujisawa [:arai]]

document for downloading source and building it here:
  https://developer.mozilla.org/en-US/docs/Simple_Thunderbird_build

whole workflow is here (Step 1 is a bit different tho):
  https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction

if you have any other question, feel free to ask here, or in IRC #introduction channel.

Comment 3

[aleth [:aleth]]

In addition, #instantbird is a good channel for chat/-specific questions, and of course #maildev for Thunderbird.

Comment 4

[Aman Mehta]

Can I skip thunderbird build? Except building thunderbird, I'm all set for next step.

Comment 5

[Tooru Fujisawa [:arai]]

although it's better if you can build and test locally, it's not required.  we can also test your patch on server.
feel free to post the patch when it's ready :)

Comment 6

[Aman Dwivedi]

Hi Tooru! I would like to take this up. Please assign it to me.

Comment 7

[Tooru Fujisawa [:arai]]

Great!

Comment 8

[Aman Dwivedi]

Attachment: BugFix1293004.patch

Hope this patch works! :)

Comment 9

[Tooru Fujisawa [:arai]]

Comment on attachment 8823223 [details] [diff] [review]
BugFix1293004.patch

Review of attachment 8823223 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for your patch :D

It looks good.
forwarding review to aleth, since I'm not module owner here.

Comment 10

[aleth [:aleth]]

Comment on attachment 8823223 [details] [diff] [review]
BugFix1293004.patch

Review of attachment 8823223 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 11

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/d16104cb778d72d07bdb978d9fb194a623d29aee