Make arrow panels white (using -moz-field) on Linux

RESOLVED FIXED in Firefox 51

Status

()

Toolkit
Themes
RESOLVED FIXED
a year ago
11 months ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
mozilla51
All
Linux
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Created attachment 8778637 [details] [diff] [review]
patch

Arrow panels are currently different on Linux for no specific reason. We use -moz-field on Windows and we should just do the same here.
Attachment #8778637 - Flags: review?(paolo.mozmail)

Comment 1

a year ago
Comment on attachment 8778637 [details] [diff] [review]
patch

Makes sense to me, for example this aligns the bookmarks menu to look like the other platform menus from the menu bar.

In the main menu, it seems the contrast of the separators between the cut, copy, and paste commands in the main menu is higher than on the other platforms. Maybe there is no reason for this difference anymore, so this can be fixed here or in a follow-up.

Out of curiosity, are the references to the "panelarrow" SVG files in "non-mac.jar.inc.mn" actually used anywhere?
Attachment #8778637 - Flags: review?(paolo.mozmail) → review+
(Assignee)

Comment 2

a year ago
(In reply to :Paolo Amadini from comment #1)
> In the main menu, it seems the contrast of the separators between the cut,
> copy, and paste commands in the main menu is higher than on the other
> platforms. Maybe there is no reason for this difference anymore, so this can
> be fixed here or in a follow-up.

It's a platform color (ThreeDShadow), ensuring that the border is visible on the background that uses a platform color as well. Judging by attachment 8778315 [details], you appear to be using an OS theme with generally stark contrasts.

> Out of curiosity, are the references to the "panelarrow" SVG files in
> "non-mac.jar.inc.mn" actually used anywhere?

Yes, on Windows and in theory on unsupported platforms falling back on the toolkit stylesheets for Windows. Linux would use this if it didn't have its own popup.css.

Comment 3

a year ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/88b2afb04d81
Make arrow panels white (using -moz-field) on Linux. r=paolo

Comment 4

a year ago
(In reply to Dão Gottwald [:dao] from comment #2)
> (In reply to :Paolo Amadini from comment #1)
> > In the main menu, it seems the contrast of the separators between the cut,
> > copy, and paste commands in the main menu is higher than on the other
> > platforms. Maybe there is no reason for this difference anymore, so this can
> > be fixed here or in a follow-up.
> 
> It's a platform color (ThreeDShadow), ensuring that the border is visible on
> the background that uses a platform color as well. Judging by attachment
> 8778315 [details], you appear to be using an OS theme with generally stark
> contrasts.

Ah, I see, the theme on my machine must be the reason. It still seems strange that everything else in the panel, like the separators below the buttons and the lines around them, doesn't use the same platform color.
(Assignee)

Comment 5

a year ago
(In reply to :Paolo Amadini from comment #4)
> strange that everything else in the panel, like the separators below the
> buttons and the lines around them, doesn't use the same platform color.

That's likely a bug... I might take care of that as part of bug 1016556.

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/88b2afb04d81
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51

Comment 7

11 months ago
(In reply to Dão Gottwald [:dao] from comment #0)
> Arrow panels are currently different on Linux for no specific reason. We use
> -moz-field on Windows and we should just do the same here.

They actually take a color from the user's theme in version 50 and lower, which was nicer IMO.

(In reply to :Paolo Amadini from comment #1)
> Makes sense to me, for example this aligns the bookmarks menu to look like
> the other platform menus from the menu bar.

Actually, this change doesn't make e.g. the bookmarks menu match the platform menus (it may just happen to make it look that way in a particular theme). As an example, with the Green-Submarine theme, the platform menus are dark green, whereas in Firefox 51, the bookmarks menu is white with the same theme. (in Firefox 50 and lower, the bookmarks menu is a lighter shade of green supplied by the theme).


Dão, could you reconsider the merits of removing the theme-specified menu background color?
Flags: needinfo?(dao+bmo)
(Assignee)

Comment 8

11 months ago
(In reply to vummiess from comment #7)
> (In reply to Dão Gottwald [:dao] from comment #0)
> > Arrow panels are currently different on Linux for no specific reason. We use
> > -moz-field on Windows and we should just do the same here.
> 
> They actually take a color from the user's theme in version 50 and lower,
> which was nicer IMO.

-moz-field is from the user's theme as well, it's just a different theme color.

> (In reply to :Paolo Amadini from comment #1)
> > Makes sense to me, for example this aligns the bookmarks menu to look like
> > the other platform menus from the menu bar.
> 
> Actually, this change doesn't make e.g. the bookmarks menu match the
> platform menus (it may just happen to make it look that way in a particular
> theme)

This is the case on Windows and Mac too, so we're consistent here.
Flags: needinfo?(dao+bmo)

Comment 9

11 months ago
(In reply to Dão Gottwald [:dao] from comment #8)
> -moz-field is from the user's theme as well, it's just a different theme
> color.
sure, but it's a theme color meant for something completely different -- indeed, the bug's goal is to "make it white" (not match the theme's look and feel, as it currently does)

> > (In reply to :Paolo Amadini from comment #1)
> This is the case on Windows and Mac too, so we're consistent here.
it's better to consistently not match the look and feel of a theme anywhere than to allow one platform to continue to match better than the others? or to make adjustments on the other platforms so that they match their themes as well as Linux currently does?
(Assignee)

Comment 10

11 months ago
(In reply to vummiess from comment #9)
> (In reply to Dão Gottwald [:dao] from comment #8)
> > -moz-field is from the user's theme as well, it's just a different theme
> > color.
> sure, but it's a theme color meant for something completely different --
> indeed, the bug's goal is to "make it white" (not match the theme's look and
> feel, as it currently does)

That was just a simplification for the sake of having a summary. The actual goal was cross-platform consistency. The mockups we get from designers always assume that arrow panels are white. Expecting them to cook up something special just for Linux isn't realistic.

> > > (In reply to :Paolo Amadini from comment #1)
> > This is the case on Windows and Mac too, so we're consistent here.
> it's better to consistently not match the look and feel of a theme anywhere

That's a mischaracterization. It's possible that this looks particularly inconsistent with your OS theme, but that's not generally the case.

> than to allow one platform to continue to match better than the others? or
> to make adjustments on the other platforms so that they match their themes
> as well as Linux currently does?

Feel free to file a new bug on making arrow panels use -moz-dialog or Menu across platforms. I suspect our UX people won't support this though.
You need to log in before you can comment on or make changes to this bug.