129347 - Sending a doc crashes SMAPI-enabled apps

Status: VERIFIED FIXED

(MailNews Core :: Simple MAPI, defect, P1)

Description

[Trix Supremo]

Sending a document from a SMAPI-enabled app causes that app to stop
responding/fail/crash.

STEPS:
1. Either enable latest mozilla or netscape trunk build to be the default mail app.
2. Close mozilla/netscape.
3. Open Wordpad/MSWord/Excel and try to send a document as an attachment.

RESULTS:
The document is sent successfully, but the app either fails to
respond/hangs/crashes.

Comment 1

[Trix Supremo]

nominating to nsbeta1+ since this causes app to crash/hang.

Comment 2

[Jochen Knuth]

Testing on Windows 98, with Mozilla Trunk, Build 2002030604, i can send documents
without crashing Wordpad/Explorer. With Quicklaunch and without.

P.S: Thanx for fixing Bug 122725, so i can test it.

Comment 3

[lchiang]

(trix, nominate is nsbeta1 only so I'm correcting the keyword.  Mail triage team
will add +/- accordingly.)

Comment 4

[Rajiv Dayal]

What is seen here is that the calling MAPI client apps hang after the send (not
really crash). This is a critical problem and is happening because the call from
mapi32.dll to Mozilla waits for a response back from Mozilla after Send
completion. If this response is not returned the call will keep waiting thus
hanging the calling application.

The mapihook part in Mozilla gets the Send call from mapi32.dll and calls
MsgCompose and waits on the Send Listener to be called back. The Send Listener
is called from MsgCompose from several places. It seems like in some cases
(maybe new cases if changes had been done to Msg Compose) the listener is not
getting called.

Most of MS Office apps create a temporary file for the file that is open when a
MAPI send is done in order to take care of any unsaved changes in the open file.
The mailnews Compose and Send interfaces had been enhanced to take in a Real
filename besides the filename of the file to be read (in this case the temporary
filename) for the contents. When the MAPI send call returns the MS Office apps
delete the temporary file. This is the reason we wait in mapi32.dll for Send to
complete before returning the MAPI call back to the MAPI client (MS Office)
apps. However in cases like these or if either Mail or Mozilla crashes this can
hang the calling MAPI client application.

An alternative to this, besides making sure that the SendListener is called in
all cases as mentioned above, is that the temporary file passed is copied to
another file with the real file name in the temp directory and that is used to
make the MsgCompose Send call. Thus the Send call to Mozilla will be
asynchronous and will become independent of Mozilla. This has some performance
impact since we make a copy of the temporary file but this will more or less
guarantee that the calling MAPI clients donot hang or suffer any data loss. This
will also make MAPI sort of independent of any future Compose changes too.

Comment 5

[Michael Buckland]

Discussed in Mail News bug meeting.  Decided to ADT1 this bug.

Comment 6

[Trix Supremo]

*** Bug 136448 has been marked as a duplicate of this bug. ***

Comment 7

[Rajiv Dayal]

Attachment: changes as per comment # 4 above

Comment 8

[Jean-Francois Ducarroz]

Comment on attachment 78748 [details] [diff] [review]
changes as per comment # 4 above

>@@ -180,8 +180,9 @@
>     //Clear the subject
>     document.getElementById("msgSubject").value = "";
> 
>+
>     SetContentAndBodyAsUnmodified();

Please remove that blank line before check in.

R=ducarroz

Comment 9

[Scott MacGregor]

Comment on attachment 78748 [details] [diff] [review]
changes as per comment # 4 above

sr=mscott

Comment 10

[Rajiv Dayal]

Thank you very much Scott for your sr and JF for your r.

Comment 11

[Trix Supremo]

Tested optimized build with rajiv's fix.  Looks good.  Docs are sent
successfully, the call that is expected back to the app is received and the app
closes the session. Tested on Word, Excel, Wordpad, and Windows Explorer.  

Comment 12

[scottputterman]

could you check this into the trunk for a day.  What other message compose
operations (not related to MAPI) need to be tested?

Comment 13

[Jaime Rodriguez, Jr.]

Pls Note: You can mark this one as Resolved/Fixed once it hits the trunk. The
ADT looks for ALL bugs with adt1.0.0 keyword (Reolved or Open). When bugs are
fixed on the 1.0 branch, pls replace adt1.0.0+ with fixed1.0.0 keyword. After QA
has verified the fix is in the branch, pls replace fixed1.0.0, with verified1.0.0.

Comment 14

[Jaime Rodriguez, Jr.]

adt1.0.0+ (on ADT's behalf) for checkin into the 1.0 branch. Pls check this in
to the branch today. After it is checked in, pls add fixed1.0.0. Once QA has
verified it on the branch, then add verified1.0.0.

Comment 15

[Rajiv Dayal]

Checked in to the trunk.

Comment 16

[Rajiv Dayal]

Attachment: Makefile.in changes for gmake builds on windows

Changes to Makefile.in for any Windows build system using gmake

Comment 17

[Scott MacGregor]

Comment on attachment 79441 [details] [diff] [review]
Makefile.in changes for gmake builds on windows

sr=mscott

Comment 18

[Asa Dotzler [:asa]]

Comment on attachment 78748 [details] [diff] [review]
changes as per comment # 4 above

a=asa (on behalf of drivers) for checkin to the 1.0 branch

Comment 19

[Asa Dotzler [:asa]]

Comment on attachment 79441 [details] [diff] [review]
Makefile.in changes for gmake builds on windows

a=asa (on behalf of drivers) for checkin to the 1.0 branch

Comment 20

[Trix Supremo]

looked at 2002041814-trunk build. Mapi works on Winword, Excel, & from Windows
Explorer.  But no Compose window appears  when trying to send a document from
Wordpad.  This is always reproducible. Will continue to evaluate whether this is
OS-specific. Since problem was found on XP, will look at W2k.

Comment 21

[Rajiv Dayal]

I found Send from Wordpad working fine, displaying the Compose window and then 
the mail send, using both Netscape and Mozilla 20020418 trunk builds on my 
WinNT wkstn machine. Also, I have already checked this into 1.0 branch. Trix, 
can u please also try tomorrow's branch build on both Win2k and XP ? thanks.

Comment 22

[Trix Supremo]

same problem still occurs with Wordpad using trunk build 2002042303.  Sending a
document from Wordpad launches the profile manager, but no Compose window is
displayed.

Comment 23

[Trix Supremo]

Since the problem occuring has nothing to do with a crash or hang and seems
isolated to WIN XP only.  Going to verify this bug and open a new bug specific
to the problem with Wordpad.

verified on 2002041806-trunk and 2002042303-1.0.0 branch