122725 - Simple mapi not working

Status: VERIFIED FIXED

(MailNews Core :: Simple MAPI, defect, P1)

Description

[Martin Poirier]

Win98Se, mozilla trunk build 20020130

Steps
1. Enable simple mapi
2. Try to use simple mapi. As an example, close mozilla, pick any file in your
system, right click it and try to send it with the "send to" context menu.

Expected result: A new compose window appears with the file I right clicked as
an attachment.

Actual result: A blank browser window appears.

additional info : I tried with a new profile and get the same problem. May be
related to bug 122351, as one user  reported that mailnews doesn't launch on win95.

Comment 1

[Rajiv Dayal]

Hi Trix,
Can u please verify this.
thanks, - Rajiv.

Comment 2

[Martin Poirier]

I guess bug 122351 wasn`t related after all, it is fixed for a few days now and
I still see this bug. Also, I see this on 2 freshly formatted machines, one with
Win95B, one with Win2000 Pro.

Comment 3

[Rajiv Dayal]

I have not been able to reproduce this after the fix for bug # 123596 has been
checked in.

Trix can u verify this one with the latest builds.

Martin, can u please also try this on your machine using any builds after
02/14/02 (20020214). This should not happen. thanks.

Comment 4

[Rajiv Dayal]

Please note : sometimes the Compose window comes behind the blank browser
window, see bug # 104237. Also currently browser window is displayed along with
the Compose
window when you do a send from a MAPI client, see bug # 119131. 

Comment 5

[Trix Supremo]

Rajiv,
Able to duplicate similar problems. Both in Mozilla & Netscape using todays
trunk builds, sending a document as an attachment in MSWord yields this error:
"Logon failed. You must log on to Microsoft Exchange to access your address
book. Error code: 'Unspecified error'."  The profile menu does display but no
Compose Window. Trying to send a document from Windows Explorer does not launch
the profile menu nor a Compose window. This was checked on WIN XP. 

The registry does show the correct default email client(either Mozilla or
Netscape).  The MAPI32.DLL used is the smart DLL (112,128 size).

WIN.INI does have:
[Mail]
MAPI=1
MAPIX=1

Comment 6

[Martin Poirier]

No it still doesn't work, and I tried everyday since feb.14th. I always get an
empry broswer window, and it is the only mozilla window open as per the windows
taskbar

Comment 7

[Jochen Knuth]

Hi,
i can confirm this bug on win xp, moz 0.9.8 and on win 98, moz 2002022603.

With a new install of moz 2002022603 i cann see in the
uninstall/install_wizard1.log file in the Mail section:
     ** szMapiBackupDll: 
     ** szDefaultMailClient: Netscape Messenger
     ** ERROR (-238): Windows Register Server:
C:\Programme\mozilla.org\Mozilla\MapiProxy.dll
     **
File.windowsRegisterServer(C:\Programme\mozilla.org\Mozilla\MapiProxy.dll\)
returned: -238

There is no MapiProxy.dll in this directory. Also the existing Mapi32.dll in the
windows/system directory is not replaced by the mozMapi32.dll

(Mozilla is set as default Mail Program)

Jochen

Comment 8

[Vadim Berezniker]

Win2k build #2002022808

I'm seeing the exact same problem ... I have tried everything.
I wiped every bit of mozilla from the system. 
Reinstalled it and still all that happens is one browser window opens without an
actual compose window.

Comment 9

[Rajiv Dayal]

As per comment # 3 .... well no wonder why the calls are not going through !!!
The MapiProxy.dll should be registered to transfer the calls from the mapi32.dll
to Mozilla. Thanks so very much Jochen Knuth for finding out these details about
MapiProxy.

I checked for some reason this MapiProxy.dll is not getting generated at all
!!!!!! I did not see this problem because on my machine earlier versions of
MapiProxy.dll is registered and since the APIs registered by this dll have not
changed since 0.94 times the calls go through on my machine. Hence everyone
trying to do this on machines which donot have MapiProxy registered in Win
registry, the calls will fail.

Need to figure out why MapiProxy.dll stopped getting built one fine day on the
trunk !!!! 

Comment 10

[Rajiv Dayal]

i mean as per comments # 7 in the above comment.

Anyway, here's the deal ... cathleen modified the makefile to enable the Windows
static build and in the process removed the EXPORT_LIBRARY directive which
caused it to stop generating MapiProxy.dll. It just generates the .lib and not
the exported dll file anymore.

Please find the patch below which will start generating the MapiProxy.dll.

Cathleen can u please review the patch below.  thanks, - Rajiv.

nominating for nsbeta1 since it does stops from Mozilla being used as a mail
application from MAPI clients like MSOffice, etc.

Comment 11

[Rajiv Dayal]

Attachment: makefile that generates MapiProxy.dll again

Comment 12

[Rajiv Dayal]

*** Bug 125880 has been marked as a duplicate of this bug. ***

Comment 13

[Vadim Berezniker]

Who else can review this patch if cathleen is busy?
Should they be CCd?

I'd really like to see this make it into 0.9.9 builds.
Especially considering how trivial the patch is.

Comment 14

[Cathleen]

Comment on attachment 72003 [details] [diff] [review]
makefile that generates MapiProxy.dll again

r=cathleen

Comment 15

[Cathleen]

let's get the patch in.  :-)
since i just saw the r= request, i didn't have time to do a full blown static
build, but i applied the change to the file, and it seems okay.

Comment 16

[Vadim Berezniker]

Does this kind of patch require sr?

Comment 17

[Rajiv Dayal]

Scott, can u please sr the patch here. thanks, - Rajiv.

Comment 18

[Scott MacGregor]

Comment on attachment 72003 [details] [diff] [review]
makefile that generates MapiProxy.dll again

sr=mscott

Comment 19

[Cathleen]

verified windows static build works.  :-)

Comment 20

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 72003 [details] [diff] [review]
makefile that generates MapiProxy.dll again

a=roc+moz for branch and trunk

Comment 21

[Vadim Berezniker]

Rajiv, please check this in when you get the chance.

Comment 22

[Vadim Berezniker]

Boris checked the patch in. 

Feel free to mark fixed.

Comment 23

[Boris Zbarsky [:bzbarsky]]

checked in, 0.9.9 branch and trunk

Comment 24

[Rajiv Dayal]

Thanks very much Boris, i was going to checkin now .. since i had to checkout
the 099 branch as i did not have one.

Marking as Fixed.

Comment 25

[Trix Supremo]

verified that latest trunk builds for mozilla and netscape 2002030603 does
contain the MapiProxy.dll and sending a document as an attachment now works. The
problem discribed is no longer duplicatible.

But a new problem has occurred which is described in bug #129347.

Marking verified