1293601 - [Fennec] The video controls are missing the time slider and show a random number at the start of video playback on YouTube

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect, P1)

Description

[Alastor Wu [:alwu]]

STR.
1. open Fennec app
2. go to https://www.youtube.com/watch?v=cxeQmF4sUJY&app=desktop
3. start playing (the control interface would not display at that time)
4. click the video, it would show the control interface 

Expected.
5. the layout of the control interface is correct

Actual.
5. the layout of the control interface is incorrect [1]

# note : if you click video again, the layout will be showed correctly.

[1] https://photos.google.com/share/AF1QipOTYFIk3yQMY5G-z_RRMGdZuuF2PAiGEcaxCoi1wfP42v_VfryTd865x9dRH3LAxQ/photo/AF1QipMYHg2iSms-s3Mkioqepb-QwyHfLFxVLM8KlvfO?key=VTVnTmwxc3BZUEFndUtFaVJucEVPd2c5QXV3cFdR

Comment 1

[Ray Lin[:ralin]]

Thank you Alastor

I suspect it is caused by the timing problem between video's state and control's init process. Since this problem is severe, I'll find out the reason ASAP.

The pushlog of narrowed regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=04821a70c739a00d12e12df651c0989441e22728&tochange=151aaa2db94d3fabe8958b61904371b8f415065d

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

From the pushlog, it looks like it was broken by https://hg.mozilla.org/mozilla-central/rev/afb94913764c

Comment 3

[Ray Lin[:ralin]]

Thanks Jared!

yes, that is a point leads the result. The other and might be the root cause is the flag: "firstshow"[0], and it affects the display of theses components[1].

I think we should remove the css rules and uplift to beta. 


[0] https://dxr.mozilla.org/mozilla-central/rev/6cf0089510fad8deb866136f5b92bbced9498447/toolkit/content/widgets/videocontrols.xml#1850-1852
[1] https://dxr.mozilla.org/mozilla-central/rev/6cf0089510fad8deb866136f5b92bbced9498447/mobile/android/themes/core/touchcontrols.css#220-225

Comment 4

[Ray Lin[:ralin]]

Attachment: Bug 1293601 - Show slider and mute button at first show on video touch control.

Review commit: https://reviewboard.mozilla.org/r/70566/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/70566/

Comment 5

[Ray Lin[:ralin]]

Comment on attachment 8779619 [details]
Bug 1293601 - Show slider and mute button at first show on video touch control.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/70566/diff/1-2/

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8779619 [details]
Bug 1293601 - Show slider and mute button at first show on video touch control.

https://reviewboard.mozilla.org/r/70566/#review68098

The commit message has a typo in it. Replace "firt" with "first".

Comment 8

[Ray Lin[:ralin]]

Comment on attachment 8779619 [details]
Bug 1293601 - Show slider and mute button at first show on video touch control.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/70566/diff/2-3/

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Ray, what about the random number? Are you still planning on fixing that?

Comment 10

[Ray Lin[:ralin]]

I guess the random is like 0:082:31 in :https://bug1290833.bmoattachments.org/attachment.cgi?id=8776524. The string is composed of "duration label + progress label", and will be separated by slider in my patch.

If not, could you provide me a screenshot? Thanks.

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

Oh! I didn't think about it that way. Cool, no worries then :)

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/590559290122
Show slider and mute button at first show on video touch control. r=jaws

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/590559290122

Comment 14

[Andrew Overholt [:overholt]]

Can we uplift this to 50 (which is also apparently affected)?

Comment 15

[Ray Lin[:ralin]]

Comment on attachment 8779619 [details]
Bug 1293601 - Show slider and mute button at first show on video touch control.

Approval Request Comment
[Feature/regressing bug #]: Fix video control incorrect layout on YouTube
[User impact if declined]: as title, time slider and mute button are missing from control
[Describe test coverage new/current, TreeHerder]: none
[Risks and why]: low rick, css which change display property only.
[String/UUID change made/needed]: none

Comment 16

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Ioana, can someone from your team please validate this fix on Nightly/Aurora? Thanks!

Comment 17

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8779619 [details]
Bug 1293601 - Show slider and mute button at first show on video touch control.

Recent regression in 50, Aurora50+

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b29125ec5eb9

Comment 19

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot_20160822-135119.png

Verified as fixed using:
Device: One A2001 (Android 5.1.1)
Builds: Firefox for Android 50.0a2 (2016-08-21) and Firefox for Android 51.0a1 (2016-08-21)