Closed Bug 1293992 Opened 8 years ago Closed 8 years ago

TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_webextension.js | xpcshell return code: 0 and more

Categories

(WebExtensions :: Untriaged, defect)

Unspecified
Windows
defect
Not set
normal

Tracking

(firefox51 fixed)

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: aleth, Assigned: jorgk-bmo)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

Windows only. 

Also TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_webextension.js | xpcshell return code: 0
So the reference to bug 1200128 was misleading, right?

This is wrong:
Last good https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=7b9fbef870b2d735e06105bfe4e9dc09518545dd
Look at
http://archive.mozilla.org/pub/thunderbird/tinderbox-builds/comm-central-win32-debug/1470669863/comm-central_win7_ix-debug_test-xpcshell-bm109-tests1-windows-build0.txt.gz

You can already find:
TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_webextension.js
It doesn't show in the tree herder summary since we had one million other Xpcshell failures at that time.

I'd say it's bug 1263011 that landed 2016-08-07 08:50:16 CEST.
Just to clarify, there are two errors:
TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_webextension.js | xpcshell return code: 0
and
TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_webextension.js | xpcshell return code: 0

Initially both where Windows only.

As of Wed Aug 17, 0:35:10
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=141fa85916e4b7afee97596269b4ec5537e5aeff
we *additionally* have
TEST-UNEXPECTED-TIMEOUT | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_delay_update_webextension.js

on *all* platforms. See bug 1295907.
Summary: TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_webextension.js | xpcshell return code: 0 → TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_webextension.js | xpcshell return code: 0 and more
Aleth, would it be an option do disable the test like we did in bug 1267612?
Flags: needinfo?(aleth)
Yes, as long as TB doesn't support webextensions, these tests don't matter.
Flags: needinfo?(aleth)
Hi Kris, like in bug 1267612 some tests related to web extensions are failing in the Thunderbird Xpcshell test suite.

To keep the review load low, I've combined to disablements into one patch. We reported the other failure in bug 1295907.

Maybe while I'm here also disable test_webextension_icons.js?
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Attachment #8782051 - Flags: review?(kmaglione+bmo)
Comment on attachment 8782051 [details] [diff] [review]
Disable tests not suitable for Thunderbird.

Review of attachment 8782051 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Jorg K (GMT+2, PTO during summer) from comment #6)
> Maybe while I'm here also disable test_webextension_icons.js?

Yes, please do.
Attachment #8782051 - Flags: review?(kmaglione+bmo) → review+
Carrying forward Kris' r+.
Attachment #8782051 - Attachment is obsolete: true
Attachment #8782080 - Flags: review+
Aleth, if you get here before the sheriffs, you could push this to inbound. Thanks.
Flags: needinfo?(aleth)
Keywords: checkin-needed
Component: General → WebExtensions
Product: Thunderbird → Toolkit
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef40e047b7b4
bug 1295907 - Disable tests not suitable for Thunderbird. r=kmag
Keywords: checkin-needed
Flags: needinfo?(aleth)
https://hg.mozilla.org/mozilla-central/rev/ef40e047b7b4
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Blocks: TBWebExtFail
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: