1294099 - AttributeError: 'Namespace' object has no attribute 'flavor' when running |mach mochitest| plain

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Andrew Halberstadt [:ahal]]

Regression from bug 1293295.

Basically I thought the 'flavor' arg would default to plain in the MochitestArgumentParser. But because the mach command redefines --flavor, this default gets lost. This only affects 'plain' because that was the only one I didn't explicitly pass in --flavor to.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1294099 - Fix 'Namespace object has no attribute 'flavor'' error when running |mach mochitest|,

Review commit: https://reviewboard.mozilla.org/r/70690/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/70690/

Comment 2

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8779768 [details]
Bug 1294099 - Fix 'Namespace object has no attribute 'flavor'' error when running |mach mochitest|,

https://reviewboard.mozilla.org/r/70690/#review68040

ship it!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe582cf4fffd
Fix 'Namespace object has no attribute 'flavor'' error when running |mach mochitest|, r=jgriffin

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fe582cf4fffd