1294194 - Don't prompt to re-save a filled login when used on a different origin

Status: RESOLVED FIXED

(Toolkit :: Password Manager, enhancement, P1)

Description

[Matthew N. [:MattN]]

In bug 1200472 and others we want to fill a login from an origin other than the one it's saved for but likely don't want to prompt to save it as a new login for that new origin upon submission. If we keep track of the guid of the login we filled then we can lookup that login and see if the username+password match upon submission to know whether to prompt or not. The state can probably be saved on the FormLike objects in _formLikeByRootElement.

Possible implementation:
1) Have LoginManagerContent.jsm's _fillForm record the guid of the filled login on the FormLike in _formLikeByRootElement.
2) Upon submission, lookup if a login was filled in _formLikeByRootElement. If so, check that the username and password matched the captured ones (in case the user corrected/changed the fields after filling) and if they match then don't prompt to remember the login as a new one.

We may want to also handle password changes where the username is the same but that may be fine in a follow-up depending on the implementation details/complexity. 

In the future we may want to track that we should auto-fill this login on this new origin but that can be left to a follow-up

Comment 1

[Matthew N. [:MattN]]

Hi Saad, can you please attach the progress you made so far even if it's not in a working state? Johann was interested in finishing it up. The same applies to your other bug too btw.

Thanks

Comment 2

[Matthew N. [:MattN]]

I guess I'll start from scratch…

Comment 3

[Matthew N. [:MattN]]

I'm going to implement only the minimal subset of this in bug 1330111 which is saving which username and password were filled. This bug will still have to handle sending that data through the prompt code and avoiding saving if it's a known login. WIP patch coming up.

Comment 4

[Matthew N. [:MattN]]

Attachment: Bug 1294194 - WIP: Don't prompt to re-save cross-origin logins that the user filled

Review commit: https://reviewboard.mozilla.org/r/108688/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/108688/

Comment 5

[Tanvi Vyas[:tanvi]]

Matt, what version of Firefox do we need to complete this bug for.  Firefox 54?  With maybe an uplift to 53.  Or can it wait until later?

Comment 6

[Matthew N. [:MattN]]

It's not targeting a specific version.

Comment 7

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

This is a P1 bug without an assignee. 

P1 are bugs which are being worked on for the current release cycle/iteration/sprint. 

If the bug is not assigned by Monday, 28 August, the bug's priority will be reset to '--'.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1294194 - Don't prompt to re-save a filled login when used on a different origin. r?MattN

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdf395eb0c64
Don't prompt to re-save a filled login when used on a different origin. r=MattN

Comment 10

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failures on /browser_autofill_track_filled_logins.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/d9bc0e4940579d50952ea8db78fb3f69dfc2b443
Push link: https://hg.mozilla.org/integration/autoland/rev/bdf395eb0c640b4deea7a122ffdd5d1b5bc20c11
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=232074463&repo=autoland&lineNumber=4729

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78ac916246b1
Don't prompt to re-save a filled login when used on a different origin. r=MattN

Comment 12

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/78ac916246b1

Comment 13

[Daniel Bodea [:danibodea]]

Do you have an example of a website where I could reproduce and verify this bug? How should I proceed to verify it?

Comment 14

[Matthew N. [:MattN]]

I think what you can do for this bug and bug 1147563 is:

1. Find a password field inside a <form> element on a public website (this might not work on sites which use CSP) and add/change the action attribute to point to a different origin e.g. action="https://localhost" (will give an error if you aren't running a localhost HTTPS server but that shouldn't affect the doorhanger behaviour which is relevant here)
2. Submit the form and save the login. If you look in logins.json of your profile folder you should see the formSubmitURL is https://localhost.
3. Reload that same login form without the action changes.
4. Only after bug 1147563 and this bug, you should get autocomplete with that new login.
5. Fill that new login via autocomplete
6. Submit the form

Expected result:
No doorhanger to save the login again (with the new formSubmitURL)