1294639 - Move --with-servo to python configure

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1294639 - Move --with-servo to python configure.

Subtly, as toolkit/moz.configure happens before toolchain tests, we
can't set MOZ_SERVO_LIBS from there. And toolkit/moz.configure is
not always included either, making things awkward to do in python
configure.

OTOH, there's only one place where MOZ_SERVO_LIBS is used, and the
corresponding setup can actually be done there (in moz.build) instead.

I think we shouldn't shy away from moving things this way.

Review commit: https://reviewboard.mozilla.org/r/71152/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/71152/

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8780411 [details]
Bug 1294639 - Move --with-servo to python configure.

https://reviewboard.mozilla.org/r/71152/#review68890

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/626e971c8ac9
Move --with-servo to python configure. r=chmanchester

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c5001d1db41
Fixup for bug 1294639 on a CLOSED TREE. a=Kwierso

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b41fac93dc90
Another fixup for bug 1294639 on a CLOSED TREE. a=Kwierso

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/626e971c8ac9
https://hg.mozilla.org/mozilla-central/rev/6c5001d1db41
https://hg.mozilla.org/mozilla-central/rev/b41fac93dc90