1294997 - Reintegrate Data Manager Password Permissions page into Permissions page

Status: RESOLVED FIXED

(SeaMonkey :: Passwords & Permissions, enhancement)

Description

[Frank-Rainer Grahl (:frg)]

The disabled hosts list is as of bug 1058438 now available as PERMISSION_SAVE_LOGINS "login-saving" in permission manager. The since bug 1188348 separate page Password Permissions in Data Manager can now be removed and the content fully reintegrated into the Permissions page.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1294997-PasswordPermissions.patch

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8780877 [details] [diff] [review]
1294997-PasswordPermissions.patch

Deletes the page and add the ability to set login saving via host. You can set allow which wasn't passible before but also does no harm. Its more or less a limitation of the permissions api that no checks are done and this isn't ignored.

Comment 3

[Philip Chee]

Comment on attachment 8780877 [details] [diff] [review]
1294997-PasswordPermissions.patch

It would be nice if the Permissions Tab has a Permissions filter so you can filter for e.g. "Password Saving"

Comment 4

[Frank-Rainer Grahl (:frg)]

>> It would be nice if the Permissions Tab has a Permissions filter so you can filter 
>> for e.g. "Password Saving"

I miss this too. Its impossible to filter for only image or cookie permissions now so for cookies I use the old dialog a lot. But I think it needs to go into the domain filter. On the tab you only see permissions from one domain.

Comment 5

[Frank-Rainer Grahl (:frg)]

For the filtering I think Bug 670681 is it. Will keep it in mind when I have some time to kill (still in this life not the next).

This bug is hopefully fixed:

https://hg.mozilla.org/comm-central/rev/4215083a2dc4

Comment 6

[Ian Neal]

Comment on attachment 8780877 [details] [diff] [review]
1294997-PasswordPermissions.patch

Already reviewed so cancelling request.