Closed Bug 1295253 Opened 4 years ago Closed 3 years ago

When the one-off search settings button is selected, clicking a urlbar result opens the search settings/preferences

Categories

(Firefox :: Address Bar, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 52
Tracking Status
firefox51 --- disabled
firefox52 --- verified

People

(Reporter: adw, Assigned: adw)

References

(Depends on 1 open bug)

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

I don't think it's possible to reproduce this with bug 1292321 fixed, but it should be fixed regardless.  This only happens in the urlbar, not the search bar.
This is still reproducible after bug 1292321 was fixed. 
Tested on Ubuntu 15.04 and Windows 10 using latest Nightly (Build ID 20160823072522).

Steps:
1. Type something in the awesomebar.
2. Press down arrow to navigate to settings gear button.
3. While settings button has focus click on a url result from dropdown.

Expected Result: The url that was clicked should be opened.
Actual Result: about:preferences#search page is opened.
Comment on attachment 8801455 [details]
Bug 1295253 - When the one-off search settings button is selected, clicking a urlbar result opens the search settings/preferences.

https://reviewboard.mozilla.org/r/86204/#review85144

::: browser/base/content/urlbarBindings.xml:377
(Diff revision 1)
> +          // key -- or if the one-off was mouse-clicked.
>            let selectedOneOff = this.popup.oneOffSearchButtons.selectedButton;
> +          if (selectedOneOff) {
> +            let useSelectedOneOff =
> +              !isMouseEvent || event.originalTarget == selectedOneOff;
> +            if (!useSelectedOneOff) {

nit: could be shortened a bit as:
if (selectedOneOff && isMouseEvent && event.originalTarget != selectedOneOff) {
  selectedOneOff = null;
}

in this case the comment seems pretty clear and I don't feel the need for the temp var, that seems instead to heavy the code flow.
Attachment #8801455 - Flags: review?(mak77) → review+
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f5814fa3d964
When the one-off search settings button is selected, clicking a urlbar result opens the search settings/preferences. r=mak
https://hg.mozilla.org/mozilla-central/rev/f5814fa3d964
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Depends on: 1311292
I have reproduced this bug as per the instruction from Comment #1 with Nightly 51.0a1 (2016-08-23) in Elementary OS 64 bit.

This bug's fix is now verified in Latest Nightly 52.0a1

Build ID 	20161020030211
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0

[testday-20161021]
I have reproduced this bug as per the instruction from Comment #1 with Nightly 51.0a1 (2016-08-15) in Windows 10, 64 bit.

This bug's fix is now verified in Latest Nightly 52.0a1 (2016-10-20).

Build ID 	20161020030211
User Agent 	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0

[testday-20161021]
User Agent  Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID  20161024030205

Thanks Sayed and Majedul for verifying this. 
I also verified the fix on Mac 10.11, latest Nightly (2016-10-24).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.