When the one-off search settings button is selected, clicking a urlbar result opens the search settings/preferences

VERIFIED FIXED in Firefox 52

Status

()

Firefox
Address Bar
P1
normal
VERIFIED FIXED
a year ago
a year ago

People

(Reporter: adw, Assigned: adw)

Tracking

(Depends on: 1 bug)

Trunk
Firefox 52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 disabled, firefox52 verified)

Details

(Whiteboard: [fxsearch])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

I don't think it's possible to reproduce this with bug 1292321 fixed, but it should be fixed regardless.  This only happens in the urlbar, not the search bar.

Comment 1

a year ago
This is still reproducible after bug 1292321 was fixed. 
Tested on Ubuntu 15.04 and Windows 10 using latest Nightly (Build ID 20160823072522).

Steps:
1. Type something in the awesomebar.
2. Press down arrow to navigate to settings gear button.
3. While settings button has focus click on a url result from dropdown.

Expected Result: The url that was clicked should be opened.
Actual Result: about:preferences#search page is opened.
Comment hidden (mozreview-request)

Comment 3

a year ago
mozreview-review
Comment on attachment 8801455 [details]
Bug 1295253 - When the one-off search settings button is selected, clicking a urlbar result opens the search settings/preferences.

https://reviewboard.mozilla.org/r/86204/#review85144

::: browser/base/content/urlbarBindings.xml:377
(Diff revision 1)
> +          // key -- or if the one-off was mouse-clicked.
>            let selectedOneOff = this.popup.oneOffSearchButtons.selectedButton;
> +          if (selectedOneOff) {
> +            let useSelectedOneOff =
> +              !isMouseEvent || event.originalTarget == selectedOneOff;
> +            if (!useSelectedOneOff) {

nit: could be shortened a bit as:
if (selectedOneOff && isMouseEvent && event.originalTarget != selectedOneOff) {
  selectedOneOff = null;
}

in this case the comment seems pretty clear and I don't feel the need for the temp var, that seems instead to heavy the code flow.
Attachment #8801455 - Flags: review?(mak77) → review+
Comment hidden (mozreview-request)

Comment 5

a year ago
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f5814fa3d964
When the one-off search settings button is selected, clicking a urlbar result opens the search settings/preferences. r=mak

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f5814fa3d964
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52

Updated

a year ago
Depends on: 1311292

Comment 7

a year ago
I have reproduced this bug as per the instruction from Comment #1 with Nightly 51.0a1 (2016-08-23) in Elementary OS 64 bit.

This bug's fix is now verified in Latest Nightly 52.0a1

Build ID 	20161020030211
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0

[testday-20161021]

Comment 8

a year ago
I have reproduced this bug as per the instruction from Comment #1 with Nightly 51.0a1 (2016-08-15) in Windows 10, 64 bit.

This bug's fix is now verified in Latest Nightly 52.0a1 (2016-10-20).

Build ID 	20161020030211
User Agent 	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0

[testday-20161021]

Comment 9

a year ago
User Agent  Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID  20161024030205

Thanks Sayed and Majedul for verifying this. 
I also verified the fix on Mac 10.11, latest Nightly (2016-10-24).
Status: RESOLVED → VERIFIED
status-firefox51: affected → disabled
status-firefox52: fixed → verified
You need to log in before you can comment on or make changes to this bug.