1311292 - If a one-off has focus, clicking a result/sugestion results in a search that is always made with default engine even if the "Search with.." says differently

Status: NEW

(Firefox :: Address Bar, defect, P3)

Description

[Liviu Cirdei]

[Affected versions]:
Nightly 52.0a1 Build ID 20161018030211

[Affected platforms]:
Tested on Windows 10 and Mac 10.10 but probably Ubuntu has the same issue.
 
[Steps to reproduce]:
1. Open Firefox with a new profile.
2. Type something in the Awesomebar (e.g. moz).
3. Press the DOWN key to navigate to one of the one-off searches engine (e.g. Twitter).
4. While the one-off has focus, using the mouse, hover over a result/suggestion from dropdown.
5. Click on the result/suggestion to perform the search.

[Expected result]:
Variant 1:
     4. The result should say "moz - Search with Google" - if Google is the default search engine.
     5. The search should be made with Google.

Variant 2: 
     4. The result should say "moz - Search with Twitter" - if Twitter is the selected one-off.
     5. The search should be made with Twitter.

No matter what variant is the correct one, there should be accordance between what the "Search with..." text say and the engine used to perform the search.
 
[Actual result]
4. The result say "moz - Search with Twitter" - if Twitter is the one-off that has focus.
5. Search is made using the default search engine (Google).

[Regression Range]
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0f3da9163d9d564d15331a259e7533385d47ae18&tochange=d6fc2c177050e2f75476a0697b100dd1cfe90ac7

Probably regressed or only exposed by the fixing of bug 1295253. 

[Note] 
1. The same behavior happens if "Change Search settings" icon has focus. In this case hovering over a result shows "Search with" + the last one off that had focus, and the search is made with the default search engine. 

2. I think this is also related to bug 1292630 - Awesomebar shows two results selected at the same time

Comment 1

[Marco Bonardo [:mak]]

we clearly need an automated test here.

Comment 2

[Julien Cristau [:jcristau]]

Mass wontfix for bugs affecting firefox 52.

Comment 3

[Drew Willcoxon :adw]

Unassigning myself from non-P1 search bugs for now so I have more time for Photon bugs.

Comment 5

[Marco Bonardo [:mak]]

This seems to be WFM now, it may still be worth adding a test.