129533 - |Cannot use const char* to initialize char*| bustage

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Roland Mainz]

2002-03-06-08-trunk build with Sun Workshop 7EA2. The build breaks due some
|Cannot use const char* to initialize char*| errors in the code ("nebiros" is
gone from the Seamonkey-Ports page, there is no RED tinderbox but it will be RED
once it's "up" again...) ...

Comment 1

[Roland Mainz]

Attachment: Patch for 2002-03-06-08-trunk

Comment 2

[jag (Peter Annema)]

Looks fine, r=/sr=jag.

Darin, what do you think?

Comment 3

[Darin Fisher]

Comment on attachment 73017 [details] [diff] [review]
Patch for 2002-03-06-08-trunk

sr=darin

Comment 4

[hacker formerly known as [e-mail]]

*** Bug 129619 has been marked as a duplicate of this bug. ***

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 73017 [details] [diff] [review]
Patch for 2002-03-06-08-trunk

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 6

[hacker formerly known as [e-mail]]

Patch has been checked in

Comment 7

[Pete Zha]

nsMsgUtils.cpp also has the same problem.
"nsMsgUtils.cpp", line 416: Error: Cannot use const char* to initialize 
416 and 410 line:
-------------------------
char*.    if (s != decodedString.get())
    {
      // extract between "=?" and "?"
      // e.g. =?ISO-2022-JP?
->416 char *p1 = strstr(*stringP, "=?");
      if (p1)
      {
        p1 += sizeof("=?")-1;         // skip "=?"
->420   char *p2 = strchr(p1, '?');   // then search for '?'
        if (p2)
        {
          char charset[kMAX_CSNAME] = "";
----------------------------

Comment 8

[Pete Zha]

Attachment: nsMsgUtils.cpp

Patch to fix nsMsgUtils.cpp

Comment 9

[Roland Mainz]

Comment on attachment 73452 [details] [diff] [review]
nsMsgUtils.cpp

r=[e-mail]

Comment 10

[[not reading bugmail]]

taking a guess that this is related to the problem I filed about it: bug 129994.

Comment 11

[Antonio.Xu]

shouldn't use strstr function,we should usr PL_strstr,it will let mozilla build 
ok on sun Platform.

Comment 12

[Roland Mainz]

Antonio.Xu wrote:
> shouldn't use strstr function, we should usr PL_strstr, it will let mozilla 
> build ok on sun Platform.

Well, then the prototype for PL_strstr() is wrong and should be fixed. And then
we have the same problem...

BTW: We should always use the OS native functions if possible and available,
they are usually better optimised and/or |inline| or compiler buildins
(currently we are slaughtering most stuff in nsCRT::* for that reason...) ...

Comment 13

[timeless]

i'm 80% certain strstr isn't available from all c libraries, so for now, please 
use the PL_ version and contact nspr about any prototype issues.

Comment 14

[Darin Fisher]

timeless, see:

netwerk/protocol/data/src/nsDataChannel.cpp:
    char *buffer = strstr(spec.get(), "data:");

netwerk/protocol/ftp/src/nsFtpConnectionThread.cpp:
        char* eol = strstr(currLine, CRLF);

so, i think strstr should be ok to use.

Comment 15

[Wan-Teh Chang]

See Kernighan and Ritchie, The C Programming Language, 2nd. Ed.,
page 250.  The function strstr() is documented.

Comment 16

[Asa Dotzler [:asa]]

Comment on attachment 73452 [details] [diff] [review]
nsMsgUtils.cpp

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 17

[hacker formerly known as [e-mail]]

Patch checked in.

Comment 18

[km]

This has just (approximately 3/30/02) shown up in a new spot 

 mozilla/netwerk/protocol/ftp/src/nsFtpConnectionThread.cpp

suggest the following fix

485c485
<         char* eol = strstr(currLine, CRLF);
---
>         char* eol = (char *) strstr(currLine, CRLF);

Comment 19

[timeless]

no. patch coming up

Comment 20

[timeless]

Attachment: correct fix for bbaetz's

Comment 21

[Brian Ryner (not reading)]

Comment on attachment 76965 [details] [diff] [review]
correct fix for bbaetz's

r=bryner

Comment 22

[Darin Fisher]

Comment on attachment 76965 [details] [diff] [review]
correct fix for bbaetz's

sr=darin

Comment 23

[Donnie Cranford]

Seeing this problem on todays Sun Solaris cvs

"nsFtpConnectionThread.cpp" , line 485: Error: Cannot use const char* to
initialize  char*.


Lets get this checked in so I can start getting Solaris dailys built and tested
again.

Thanks

Donnie

-dcran-

Comment 24

[timeless]

Comment on attachment 76965 [details] [diff] [review]
correct fix for bbaetz's

checked in a=asa

Comment 25

[Tracy Walker [:tracy]]

verfied checked in