Closed Bug 1295671 Opened 3 years ago Closed 3 years ago

Reliably detect use of the system libpng in nsPNGDecoder

Categories

(Core :: ImageLib, defect, minor)

defect
Not set
minor

Tracking

()

VERIFIED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: glennrp+bmo, Assigned: glennrp+bmo)

Details

Attachments

(1 file, 2 obsolete files)

nsPNGDecoder is using "#ifndef PNGLCONF_H" to detect if the system libpng is being used. Unfortunately PNGLIBCONF_H can be defined by the system libpng as well.  We should use the MOZ_EMBEDDED_LIBPNG flag instead.
Assignee: nobody → glennrp+bmo
Status: NEW → ASSIGNED
Attached patch v00-1295671-detect-system-libpng (obsolete) — Splinter Review
Attachment #8781640 - Flags: review?(seth.bugzilla)
Attached patch v01-1295671-detect-system-libpng (obsolete) — Splinter Review
Rebased.
Attachment #8781640 - Attachment is obsolete: true
Attachment #8781640 - Flags: review?(seth.bugzilla)
Attachment #8783009 - Flags: review?(seth.bugzilla)
Please "try", ok to combine with bug #1296946
Flags: needinfo?(ryanvm)
Comment on attachment 8783009 [details] [diff] [review]
v01-1295671-detect-system-libpng

Try was all green.
Simplified the patch.  We can address the bracketing style issue in another bug.
Attachment #8783009 - Attachment is obsolete: true
Attachment #8783009 - Flags: review?(seth.bugzilla)
Attachment #8785567 - Flags: review?(jmuizelaar)
Attachment #8785567 - Flags: review?(seth.bugzilla)
Attachment #8785567 - Flags: review?(tnikkel)
Attachment #8785567 - Flags: review?(tnikkel) → review+
Keywords: checkin-needed
Attachment #8785567 - Flags: review?(seth.bugzilla)
Attachment #8785567 - Flags: review?(jmuizelaar)
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f25b22784bc9
Detect use of system libpng in nsPNGDecoder.cpp. r=tn
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f25b22784bc9
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.