Closed
Bug 1295671
Opened 8 years ago
Closed 8 years ago
Reliably detect use of the system libpng in nsPNGDecoder
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
VERIFIED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: glennrp+bmo, Assigned: glennrp+bmo)
Details
Attachments
(1 file, 2 obsolete files)
|
1.18 KB,
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
nsPNGDecoder is using "#ifndef PNGLCONF_H" to detect if the system libpng is being used. Unfortunately PNGLIBCONF_H can be defined by the system libpng as well. We should use the MOZ_EMBEDDED_LIBPNG flag instead.
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → glennrp+bmo
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8781640 -
Flags: review?(seth.bugzilla)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Rebased.
Attachment #8781640 -
Attachment is obsolete: true
Attachment #8781640 -
Flags: review?(seth.bugzilla)
Attachment #8783009 -
Flags: review?(seth.bugzilla)
|
|
Assignee | |
Comment 3•8 years ago
|
||
Please "try", ok to combine with bug #1296946
Flags: needinfo?(ryanvm)
|
||
Comment 4•8 years ago
|
||
Flags: needinfo?(ryanvm)
|
|
Assignee | |
Comment 5•8 years ago
|
||
Comment on attachment 8783009 [details] [diff] [review]
v01-1295671-detect-system-libpng
Try was all green.
| Comment hidden (obsolete) |
|
|
Assignee | |
Comment 7•8 years ago
|
||
Simplified the patch. We can address the bracketing style issue in another bug.
Attachment #8783009 -
Attachment is obsolete: true
Attachment #8783009 -
Flags: review?(seth.bugzilla)
Attachment #8785567 -
Flags: review?(jmuizelaar)
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8785567 -
Flags: review?(seth.bugzilla)
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8785567 -
Flags: review?(tnikkel)
|
||
Updated•8 years ago
|
Attachment #8785567 -
Flags: review?(tnikkel) → review+
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
|
|
||
Updated•8 years ago
|
Attachment #8785567 -
Flags: review?(seth.bugzilla)
Attachment #8785567 -
Flags: review?(jmuizelaar)
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f25b22784bc9
Detect use of system libpng in nsPNGDecoder.cpp. r=tn
Keywords: checkin-needed
|
||
Comment 9•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
|
|
Assignee | |
Updated•8 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•