Closed Bug 1295671 Opened 5 years ago Closed 5 years ago
Reliably detect use of the system libpng in ns
nsPNGDecoder is using "#ifndef PNGLCONF_H" to detect if the system libpng is being used. Unfortunately PNGLIBCONF_H can be defined by the system libpng as well. We should use the MOZ_EMBEDDED_LIBPNG flag instead.
Assignee: nobody → glennrp+bmo
Status: NEW → ASSIGNED
Please "try", ok to combine with bug #1296946
Comment on attachment 8783009 [details] [diff] [review] v01-1295671-detect-system-libpng Try was all green.
Simplified the patch. We can address the bracketing style issue in another bug.
Attachment #8785567 - Flags: review?(tnikkel) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f25b22784bc9 Detect use of system libpng in nsPNGDecoder.cpp. r=tn
You need to log in before you can comment on or make changes to this bug.