1295788 - Remove layout.css.display-contents.enabled pref

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Mats Palmgren (inactive)]

display:contents was enabled by default in v37 (bug 1105369), so I think
we can remove the layout.css.display-contents.enabled pref now.

Comment 2

[Jeremy Chen ([e-mail])]

Attachment: Bug 1295788 - Remove layout.css.display-contents.enabled pref.

1. Remove the preference setting in reftest.list
2. Remove the preference guard in property_database.js
3. Remove the callback function of preference change
4. Remove the preference from all.js

Review commit: https://reviewboard.mozilla.org/r/93384/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93384/

Comment 3

[Mats Palmgren (inactive)]

Comment on attachment 8811182 [details]
Bug 1295788 - Remove layout.css.display-contents.enabled pref.

https://reviewboard.mozilla.org/r/93384/#review93456

LGTM, thanks.

Comment 4

[Jeremy Chen ([e-mail])]

Comment on attachment 8811182 [details]
Bug 1295788 - Remove layout.css.display-contents.enabled pref.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93384/diff/1-2/

Comment 5

[Jeremy Chen ([e-mail])]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d90be976c5ed

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5ee658f3937
Remove layout.css.display-contents.enabled pref.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b5ee658f3937

Comment 8

[Gerry Chang [:gchang]]

We've built 51 RC. Mark 51 won't fix.

Comment 9

[Chris Mills [:cmills]]

I've updated the browser compat information on the display page to mention this (see footnote 2)

https://developer.mozilla.org/en-US/docs/Web/CSS/display#Browser_compatibility

I've also added a note to the Fx53 release notes:

https://developer.mozilla.org/en-US/Firefox/Releases/53#CSS

Let me know if you think anything else needs updating.