Only use build id for Intel blocklist entry 'FEATURE_FAILURE_BUG_1018278'

RESOLVED FIXED in Firefox 51

Status

()

Core
Graphics
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: ethlin, Assigned: Lenzak)

Tracking

(Blocks: 1 bug)

unspecified
mozilla51
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(3 attachments, 7 obsolete attachments)

733.95 KB, image/png
Details
1.82 KB, patch
milan
: review+
Details | Diff | Splinter Review
928 bytes, patch
Lenzak
: review+
Details | Diff | Splinter Review
(Reporter)

Description

2 years ago
In bug 1018278, we add this entry[1] to blocklist:
    APPEND_TO_DRIVER_BLOCKLIST(OperatingSystem::Windows,
        (nsAString&) GfxDriverInfo::GetDeviceVendor(VendorIntel), (GfxDeviceFamily*) GfxDriverInfo::GetDeviceFamily(IntelHD3000),
      GfxDriverInfo::allFeatures, nsIGfxInfo::FEATURE_BLOCKED_DRIVER_VERSION,
      DRIVER_LESS_THAN_OR_EQUAL, V(8,15,10,2321), "FEATURE_FAILURE_BUG_1018278", "8.15.10.2342");

Per discussion in bug 1294771, we should investigate what we are trying to block and see if we should use build id for this.

[1] https://hg.mozilla.org/mozilla-central/annotate/054d4856cea6150a6638e5daf7913713281af97d/widget/windows/GfxInfo.cpp#l1057
(Reporter)

Updated

2 years ago
Whiteboard: [gfx-noted]
(Assignee)

Updated

2 years ago
Assignee: nobody → cleu
(Assignee)

Comment 1

2 years ago
Created attachment 8783393 [details] [diff] [review]
Change DRIVER_LESS_THAN_OR_EQUAL to DRIVER_BUILD_ID_LESS_THAN

I will test it on a PC based on an intel i3-2125 with Intel HD3000 iGP
(Assignee)

Comment 2

2 years ago
Created attachment 8785142 [details]
snapshot.png
(Assignee)

Updated

2 years ago
Attachment #8783393 - Attachment description: WIP - Change DRIVER_LESS_THAN_OR_EQUAL to DRIVER_BUILD_ID_LESS_THAN → Change DRIVER_LESS_THAN_OR_EQUAL to DRIVER_BUILD_ID_LESS_THAN
(Assignee)

Comment 3

2 years ago
Comment on attachment 8783393 [details] [diff] [review]
Change DRIVER_LESS_THAN_OR_EQUAL to DRIVER_BUILD_ID_LESS_THAN

Review of attachment 8783393 [details] [diff] [review]:
-----------------------------------------------------------------

I've tested it under an Intel i3-2125 with HD3000 with driver build id 2321.

It seems that gecko can still block it from executing D2D with our blacklist changed.
Attachment #8783393 - Flags: review?(ethlin)
(Reporter)

Comment 4

2 years ago
Comment on attachment 8783393 [details] [diff] [review]
Change DRIVER_LESS_THAN_OR_EQUAL to DRIVER_BUILD_ID_LESS_THAN

Review of attachment 8783393 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/GfxInfo.cpp
@@ +1067,4 @@
>      APPEND_TO_DRIVER_BLOCKLIST(OperatingSystem::Windows,
>          (nsAString&) GfxDriverInfo::GetDeviceVendor(VendorIntel), (GfxDeviceFamily*) GfxDriverInfo::GetDeviceFamily(IntelHD3000),
>        GfxDriverInfo::allFeatures, nsIGfxInfo::FEATURE_BLOCKED_DRIVER_VERSION,
> +      DRIVER_BUILD_ID_LESS_THAN, 2322, "FEATURE_FAILURE_BUG_1018278", "Intel Driver build number < 2322");

I think you should add DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL and implement it. The last parameter is suggested version, so maybe we should suggest 2342.
Attachment #8783393 - Flags: review?(ethlin)
(Assignee)

Comment 5

2 years ago
Created attachment 8785184 [details] [diff] [review]
Implement DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL
(Assignee)

Comment 6

2 years ago
Created attachment 8785185 [details] [diff] [review]
Change DRIVER_LESS_THAN_OR_EQUAL to DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL
Attachment #8783393 - Attachment is obsolete: true
(Assignee)

Comment 7

2 years ago
Created attachment 8785186 [details] [diff] [review]
Change DRIVER_LESS_THAN_OR_EQUAL to DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL
Attachment #8785185 - Attachment is obsolete: true
(Assignee)

Updated

2 years ago
Attachment #8785184 - Flags: review?(ethlin)
(Assignee)

Updated

2 years ago
Attachment #8785186 - Flags: review?(ethlin)
(Assignee)

Comment 8

2 years ago
Created attachment 8785776 [details] [diff] [review]
Change DRIVER_LESS_THAN_OR_EQUAL to DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL

Change recommended driver version to recommended build id.
Attachment #8785186 - Attachment is obsolete: true
Attachment #8785186 - Flags: review?(ethlin)
Attachment #8785776 - Flags: review?(ethlin)
(Reporter)

Updated

2 years ago
Attachment #8785184 - Flags: review?(ethlin) → review+
(Reporter)

Updated

2 years ago
Attachment #8785776 - Flags: review?(ethlin) → review+
(Assignee)

Updated

2 years ago
Attachment #8785184 - Flags: review?(jmuizelaar)
(Assignee)

Updated

2 years ago
Attachment #8785776 - Flags: review?(jmuizelaar)
(Assignee)

Updated

2 years ago
Attachment #8785184 - Flags: review?(jmuizelaar)
(Assignee)

Updated

2 years ago
Attachment #8785776 - Flags: review?(jmuizelaar)
(Assignee)

Updated

2 years ago
Attachment #8785184 - Flags: review?(milan)
(Assignee)

Updated

2 years ago
Attachment #8785776 - Flags: review?(milan)
(Reporter)

Updated

2 years ago
Blocks: 1295902
Comment on attachment 8785184 [details] [diff] [review]
Implement DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL

Review of attachment 8785184 [details] [diff] [review]:
-----------------------------------------------------------------

We need to add support in BlacklistComparatorToComparisonOp for this new operator, as well as for the previously added but missed DRIVER_BUILD_ID_LESS_THAN.  Otherwise, looks good.
Attachment #8785184 - Flags: review?(milan) → review-
Comment on attachment 8785776 [details] [diff] [review]
Change DRIVER_LESS_THAN_OR_EQUAL to DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL

Review of attachment 8785776 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/GfxInfo.cpp
@@ +1067,4 @@
>      APPEND_TO_DRIVER_BLOCKLIST(OperatingSystem::Windows,
>          (nsAString&) GfxDriverInfo::GetDeviceVendor(VendorIntel), (GfxDeviceFamily*) GfxDriverInfo::GetDeviceFamily(IntelHD3000),
>        GfxDriverInfo::allFeatures, nsIGfxInfo::FEATURE_BLOCKED_DRIVER_VERSION,
> +      DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL, 2321, "FEATURE_FAILURE_BUG_1018278", "2342");

It is probably more instructive to display the recommended version as "X.X.X.2342" instead of just 2342, to help people that do not understand Intel's driver versioning scheme.
Attachment #8785776 - Flags: review?(milan) → review+
(Assignee)

Comment 11

2 years ago
Created attachment 8787038 [details] [diff] [review]
part1: Implement DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL r=ethlin

Add BUILD_ID_LESS_THAN and BUILD_ID_LESS_THAN_OR_EQUAL in BlacklistComparatorToComparisonsOp
Attachment #8785184 - Attachment is obsolete: true
(Assignee)

Comment 12

2 years ago
Created attachment 8787044 [details] [diff] [review]
Change DRIVER_LESS_THAN_OR_EQUAL to DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL r=ethlin

Revert recommended build id back to recommended driver version
Attachment #8785776 - Attachment is obsolete: true
(Assignee)

Updated

2 years ago
Attachment #8787038 - Flags: review?(milan)
(Assignee)

Comment 13

2 years ago
Created attachment 8787046 [details] [diff] [review]
Change DRIVER_LESS_THAN_OR_EQUAL to DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL  r=ethlin r=milan
Attachment #8787044 - Attachment is obsolete: true
Attachment #8787046 - Flags: review+
(Assignee)

Comment 14

2 years ago
Created attachment 8787047 [details] [diff] [review]
part2: Change DRIVER_LESS_THAN_OR_EQUAL to DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL r=ethlin r=milan

Change recommended version number to X.X.X.(build id)
Attachment #8787046 - Attachment is obsolete: true
Attachment #8787047 - Flags: review+
(Assignee)

Updated

2 years ago
Blocks: 1299757
Attachment #8787038 - Flags: review?(milan) → review+
(Assignee)

Updated

2 years ago
Attachment #8787038 - Attachment description: Implement DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL r=ethlin → part1: Implement DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL r=ethlin
(Assignee)

Updated

2 years ago
Attachment #8787047 - Attachment description: Change DRIVER_LESS_THAN_OR_EQUAL to DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL r=ethlin r=milan → part2: Change DRIVER_LESS_THAN_OR_EQUAL to DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL r=ethlin r=milan
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 16

2 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/de297d5d37b0
Implement DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL. r=milan
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d11d2b3af0b
Change DRIVER_LESS_THAN_OR_EQUAL to DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL r=ethlin r=milan
Keywords: checkin-needed

Comment 17

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/de297d5d37b0
https://hg.mozilla.org/mozilla-central/rev/5d11d2b3af0b
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.