1295899 - Only use build id for Intel blocklist entry 'FEATURE_FAILURE_BUG_1018278'

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Ethan Lin[:ethlin]]

In bug 1018278, we add this entry[1] to blocklist:
    APPEND_TO_DRIVER_BLOCKLIST(OperatingSystem::Windows,
        (nsAString&) GfxDriverInfo::GetDeviceVendor(VendorIntel), (GfxDeviceFamily*) GfxDriverInfo::GetDeviceFamily(IntelHD3000),
      GfxDriverInfo::allFeatures, nsIGfxInfo::FEATURE_BLOCKED_DRIVER_VERSION,
      DRIVER_LESS_THAN_OR_EQUAL, V(8,15,10,2321), "FEATURE_FAILURE_BUG_1018278", "8.15.10.2342");

Per discussion in bug 1294771, we should investigate what we are trying to block and see if we should use build id for this.

[1] https://hg.mozilla.org/mozilla-central/annotate/054d4856cea6150a6638e5daf7913713281af97d/widget/windows/GfxInfo.cpp#l1057

Comment 1

[Michael Leu[:Lenzak](UTC+8)]

Attachment: Change DRIVER_LESS_THAN_OR_EQUAL to DRIVER_BUILD_ID_LESS_THAN

I will test it on a PC based on an intel i3-2125 with Intel HD3000 iGP

Comment 2

[Michael Leu[:Lenzak](UTC+8)]

Attachment: snapshot.png

Comment 3

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8783393 [details] [diff] [review]
Change DRIVER_LESS_THAN_OR_EQUAL to DRIVER_BUILD_ID_LESS_THAN

Review of attachment 8783393 [details] [diff] [review]:
-----------------------------------------------------------------

I've tested it under an Intel i3-2125 with HD3000 with driver build id 2321.

It seems that gecko can still block it from executing D2D with our blacklist changed.

Comment 4

[Ethan Lin[:ethlin]]

Comment on attachment 8783393 [details] [diff] [review]
Change DRIVER_LESS_THAN_OR_EQUAL to DRIVER_BUILD_ID_LESS_THAN

Review of attachment 8783393 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/GfxInfo.cpp
@@ +1067,4 @@
>      APPEND_TO_DRIVER_BLOCKLIST(OperatingSystem::Windows,
>          (nsAString&) GfxDriverInfo::GetDeviceVendor(VendorIntel), (GfxDeviceFamily*) GfxDriverInfo::GetDeviceFamily(IntelHD3000),
>        GfxDriverInfo::allFeatures, nsIGfxInfo::FEATURE_BLOCKED_DRIVER_VERSION,
> +      DRIVER_BUILD_ID_LESS_THAN, 2322, "FEATURE_FAILURE_BUG_1018278", "Intel Driver build number < 2322");

I think you should add DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL and implement it. The last parameter is suggested version, so maybe we should suggest 2342.

Comment 5

[Michael Leu[:Lenzak](UTC+8)]

Attachment: Implement DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL

Comment 6

[Michael Leu[:Lenzak](UTC+8)]

Attachment: Change DRIVER_LESS_THAN_OR_EQUAL to DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL

Comment 7

[Michael Leu[:Lenzak](UTC+8)]

Attachment: Change DRIVER_LESS_THAN_OR_EQUAL to DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL

Comment 8

[Michael Leu[:Lenzak](UTC+8)]

Attachment: Change DRIVER_LESS_THAN_OR_EQUAL to DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL

Change recommended driver version to recommended build id.

Comment 9

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8785184 [details] [diff] [review]
Implement DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL

Review of attachment 8785184 [details] [diff] [review]:
-----------------------------------------------------------------

We need to add support in BlacklistComparatorToComparisonOp for this new operator, as well as for the previously added but missed DRIVER_BUILD_ID_LESS_THAN.  Otherwise, looks good.

Comment 10

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8785776 [details] [diff] [review]
Change DRIVER_LESS_THAN_OR_EQUAL to DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL

Review of attachment 8785776 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/GfxInfo.cpp
@@ +1067,4 @@
>      APPEND_TO_DRIVER_BLOCKLIST(OperatingSystem::Windows,
>          (nsAString&) GfxDriverInfo::GetDeviceVendor(VendorIntel), (GfxDeviceFamily*) GfxDriverInfo::GetDeviceFamily(IntelHD3000),
>        GfxDriverInfo::allFeatures, nsIGfxInfo::FEATURE_BLOCKED_DRIVER_VERSION,
> +      DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL, 2321, "FEATURE_FAILURE_BUG_1018278", "2342");

It is probably more instructive to display the recommended version as "X.X.X.2342" instead of just 2342, to help people that do not understand Intel's driver versioning scheme.

Comment 11

[Michael Leu[:Lenzak](UTC+8)]

Attachment: part1: Implement DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL r=ethlin

Add BUILD_ID_LESS_THAN and BUILD_ID_LESS_THAN_OR_EQUAL in BlacklistComparatorToComparisonsOp

Comment 12

[Michael Leu[:Lenzak](UTC+8)]

Attachment: Change DRIVER_LESS_THAN_OR_EQUAL to DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL r=ethlin

Revert recommended build id back to recommended driver version

Comment 13

[Michael Leu[:Lenzak](UTC+8)]

Attachment: Change DRIVER_LESS_THAN_OR_EQUAL to DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL r=ethlin r=milan

Comment 14

[Michael Leu[:Lenzak](UTC+8)]

Attachment: part2: Change DRIVER_LESS_THAN_OR_EQUAL to DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL r=ethlin r=milan

Change recommended version number to X.X.X.(build id)

Comment 15

[Michael Leu[:Lenzak](UTC+8)]

Here is tryserver result
https://treeherder.mozilla.org/#/jobs?repo=try&revision=025d280a4290&selectedJob=26942995

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/de297d5d37b0
Implement DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL. r=milan
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d11d2b3af0b
Change DRIVER_LESS_THAN_OR_EQUAL to DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL r=ethlin r=milan

Comment 17

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/de297d5d37b0
https://hg.mozilla.org/mozilla-central/rev/5d11d2b3af0b